test: failure in interface_usdt_validation.py #25764

1. 
   fanquake commented at 12:19 PM on August 1, 2022: member

   https://cirrus-ci.com/task/5553601580892160?logs=ci#L4244:

    test  2022-08-01T12:14:24.104000Z TestFramework (INFO): handle_blockconnected(): ConnectedBlock(hash=2f97f65fda63aba081bf2867f7f99657c39436306c4aed3c899264b8bde7c5ab height=202, transactions=1, inputs=1, sigops=0, duration=517) 
    test  2022-08-01T12:14:24.104000Z TestFramework (INFO): handle_blockconnected(): ConnectedBlock(hash=54d4bd414e5de85cee4dc5f1e7bcf4e358cf6e7ce556647debe2e9d007459ec7 height=201, transactions=1, inputs=1, sigops=0, duration=338) 
    test  2022-08-01T12:14:24.148000Z TestFramework (INFO): check that we traced 2 blocks 
    test  2022-08-01T12:14:24.149000Z TestFramework (ERROR): Assertion failed 
                                      Traceback (most recent call last):
                                        File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main
                                          self.run_test()
                                        File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/interface_usdt_validation.py", line 131, in run_test
                                          assert_equal(BLOCKS_EXPECTED, blocks_checked)
                                        File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/util.py", line 52, in assert_equal
                                          raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
                                      AssertionError: not(2 == 0)
   

2. fanquake added the label Bug on Aug 1, 2022
3. fanquake added the label Tests on Aug 1, 2022
4. MarcoFalke added this to the milestone 24.0 on Aug 1, 2022
5. 
   0xB10C commented at 3:19 PM on August 4, 2022: contributor

   I'll look into this.

6. 
   theStack commented at 10:29 AM on August 5, 2022: contributor

   Another run with this assertion (assert_equal(BLOCKS_EXPECTED, blocks_checked)) failing: https://cirrus-ci.com/task/4529853595648000?logs=ci#L4233

7. 
   0xB10C commented at 10:45 AM on August 6, 2022: contributor

   Some notes for now:

   • I can't reproduce this locally. It might be a timing thing. Will further test in the CI runner.
   • I first though increasing the timeout could help. https://github.com/bitcoin/bitcoin/blob/b1a2021f78099c17360dc2179cbcb948059b5969/test/functional/interface_usdt_validation.py#L127 However, the logs show that handle_blockconnected() is correctly being called twice, which means the timeout is fine.
   • I'm not sure why incrementing blocks_checked in handle_blockconnected() sometimes has no effect on the value checked in the assert.
8. 
   0xB10C commented at 10:53 AM on August 6, 2022: contributor

   It's clear when looking at the stderr output, e.g. as attached in #25793. It seems like the order of block_connected events isn't something we should rely on in the tests.

   stderr:
   ...
   AssertionError: not(524a502fb9f972c220da42f2658ee2c4e63238a58b2b470505fabbae4482279b == 740e218334005cfc4c988053083a3d3ba5ba59cd8530030e42a87a4080fbffe8)
   ...
   AssertionError: not(740e218334005cfc4c988053083a3d3ba5ba59cd8530030e42a87a4080fbffe8 == 524a502fb9f972c220da42f2658ee2c4e63238a58b2b470505fabbae4482279b)
   

9. 0xB10C referenced this in commit 275f523e3a on Aug 6, 2022
10. 0xB10C referenced this in commit 0532aa7444 on Aug 6, 2022
11. 
    jonatack commented at 12:46 PM on August 8, 2022: contributor

    https://cirrus-ci.com/task/6722929781112832?logs=ci#L3968

12. MarcoFalke closed this on Aug 10, 2022

    ---

13. MarcoFalke referenced this in commit aac200801b on Aug 10, 2022
14. sidhujag referenced this in commit 979c35aeb8 on Aug 10, 2022
15. Rspigler referenced this in commit e14b220c7e on Aug 21, 2022
16. janus referenced this in commit bf6d14dc73 on Jan 20, 2023
17. bitcoin locked this on Aug 10, 2023

Milestone
24.0