doc: Clarify multiple wallets for same signer (final) #25893

pull Rspigler wants to merge 3 commits into bitcoin:master from Rspigler:external_signer changing 1 files +1 −0

Rspigler commented at 3:54 AM on August 21, 2022: contributor

#25891
add multiple wallets creation info d500b03e75
Rspigler renamed this:
~~doc: larify multiple wallets for same signer (final)~~
doc: Clarify multiple wallets for same signer (final)
on Aug 21, 2022
DrahtBot added the label Docs on Aug 21, 2022
Rspigler commented at 7:53 AM on August 21, 2022: contributor

CI error #25644
Merge branch 'bitcoin:master' into external_signer 0af1b5215e
Remove 'identical' f78f6389ab

in doc/external-signer.md:42 in d500b03e75 outdated

  38 | @@ -39,6 +39,7 @@ Create a wallet, this automatically imports the public keys:
  39 |  ```sh
  40 |  $ bitcoin-cli createwallet "hww" true true "" true true true
  41 |  ```
  42 | +Creating `N` distinctly named wallets with the same external signer, will create `N` identical wallets, with the same seed, account, and addresses - just named differently. New wallet creation will not automatically increment the `account` path.

luke-jr commented at 9:53 PM on August 26, 2022:

Not identical, since metadata can(will?) differ

Rspigler commented at 4:46 AM on August 27, 2022: contributor

I'll squash later if I get ACKs
DrahtBot commented at 9:33 AM on September 23, 2022: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
achow101 commented at 3:19 PM on October 13, 2022: member

I'll squash later if I get ACKs

Generally people only ACK things that are in a state where they could be merged, so it is preferable for PRs to be squashed (and rebased if needed) before seeking ACKs,
maflcko commented at 4:24 PM on October 17, 2022: member

Maybe close for now and reopen when it is ready? This is a one-line doc change, so doesn't seem worth it to sit several months?
pablomartin4btc commented at 3:41 PM on October 28, 2022: member

I guess this could be something unexpected from the point of view of a user, unless I'm missing something here, maybe should be specified as a warning? (e.g. "be aware of...")
hernanmarino commented at 6:14 PM on October 28, 2022: contributor

Simple but nice addition to the documentation. @Rspigler any plans of squashing this so it can be merged ?
fanquake commented at 11:51 AM on December 5, 2022: member

Closing for now. @Rspigler please comment and this can be re-opened, after which you can squash the commits (pushing to the branch of a closed PR will break GitHub). @Sjors maybe you can also review?
fanquake closed this on Dec 5, 2022
bitcoin locked this on Dec 5, 2023