refactor: Move ChainstateManager options into m_options struct #25905

1. 
   ryanofsky commented at 5:34 pm on August 22, 2022: contributor

   Move ChainstateManager options into m_options struct to simplify class initialization, organize class members, and to name external option variables differently than internal state variables.

   This change was originally in #25862, but it was suggested to split off in #25862 (review) so it could be merged earlier and reduce conflicts with other PRs.

2. refactor: Move ChainstateManager options into m_options struct

   Move ChainstateManager options into m_options struct to simplify class
   initialization, organize class members, and to name external option variables
   differently than internal state variables.
   
   This change was originally in #25862, but it was suggested to split off in
   https://github.com/bitcoin/bitcoin/pull/25862#discussion_r951459817 so it could
   be merged earlier and reduce conflicts with other PRs.

   7bc33a88f7
3. DrahtBot added the label Refactoring on Aug 22, 2022
4. 
   DrahtBot commented at 1:21 am on August 23, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #25862 (refactor, kernel: Remove gArgs accesses from dbwrapper and txdb by ryanofsky)
   • #25781 (Remove almost all blockstorage globals by MarcoFalke)
   • #25704 (refactor: Remove almost all validation option globals by MarcoFalke)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. MarcoFalke requested review from dongcarl on Aug 23, 2022
6. 
   naumenkogs commented at 7:35 am on August 24, 2022: member

   ACK 6db2c00adbefb34103af2ccf81bdab77197f64ab
7. in src/validation.h:881 in 6db2c00adb outdated

   877@@ -881,6 +878,7 @@ class ChainstateManager
   878      */
   879     RecursiveMutex& GetMutex() const LOCK_RETURNED(::cs_main) { return ::cs_main; }
   880 
   881+    Options m_options;
   

   ---

   ---

   

   MarcoFalke commented at 8:40 am on August 24, 2022:

   Any reason to remove the const?

   ---

   

   ryanofsky commented at 12:40 pm on August 24, 2022:

   re: #25905 (review)

   Any reason to remove the const?

   Nope, added const

8. ryanofsky force-pushed on Aug 24, 2022
9. 
   ryanofsky commented at 12:45 pm on August 24, 2022: contributor

   Updated 6db2c00adbefb34103af2ccf81bdab77197f64ab -> 7bc33a88f7817c7ff9cb5f9dcc751c2d2937ead0 (pr/csmopt.1 -> pr/csmopt.2, compare) adding const as suggested
10. 
    naumenkogs commented at 7:41 am on August 25, 2022: member

    ACK 7bc33a88f7817c7ff9cb5f9dcc751c2d2937ead0
11. MarcoFalke merged this on Aug 25, 2022
12. MarcoFalke closed this on Aug 25, 2022

    ---

13. sidhujag referenced this in commit 819ef20dda on Aug 25, 2022
14. bitcoin locked this on Aug 25, 2023

Contributors
ryanofsky DrahtBot naumenkogs MarcoFalke

Review Requested
dongcarl

Labels
Refactoring