test: refactor `RPCPackagesTest` to use `MiniWallet` #25986

  37 | @@ -48,33 +38,34 @@ def assert_testres_equal(self, package_hex, testres_expected):
  38 |          shuffled_testres = [testres_expected[i] for i in shuffled_indeces]
  39 |          assert_equal(shuffled_testres, self.nodes[0].testmempoolaccept(shuffled_package))
  40 |  
  41 | +    def create_tx_chain(self, chain_length=25):

---

  47 | +            tx = self.wallet.create_self_transfer(utxo_to_spend=chaintip_utxo)
  48 | +            chaintip_utxo = tx["new_utxo"]
  49 | +            chain_hex.append(tx["hex"])
  50 | +            chain_txns.append(tx["tx"])
  51 | +
  52 | +        return (chain_hex, chain_txns)

---

  66 | -                "scriptPubKey": coinbase["vout"][0]["scriptPubKey"],
  67 | -            })
  68 | +        self.wallet = MiniWallet(self.nodes[0])
  69 |  
  70 | +        self.generate(self.wallet, COINBASE_MATURITY + 100)  # blocks generated for inputs
  71 | +        self.wallet.rescan_utxos()

---

  79 | -            rawtx = node.createrawtransaction([{"txid": coin["txid"], "vout": 0}],
  80 | -                {self.address : coin["amount"] - Decimal("0.0001")})
  81 | -            signedtx = node.signrawtransactionwithkey(hexstring=rawtx, privkeys=self.privkeys)
  82 | -            assert signedtx["complete"]
  83 | -            testres = node.testmempoolaccept([signedtx["hex"]])
  84 | +            tx = self.wallet.create_self_transfer(fee_rate=Decimal("0.0001"))["tx"]

---

 139 | -                                           {self.address : coin["amount"] - Decimal("0.999")})
 140 | -        tx_high_fee_signed = node.signrawtransactionwithkey(hexstring=tx_high_fee_raw, privkeys=self.privkeys)
 141 | -        assert tx_high_fee_signed["complete"]
 142 | -        tx_high_fee = tx_from_hex(tx_high_fee_signed["hex"])
 143 | -        testres_high_fee = node.testmempoolaccept([tx_high_fee_signed["hex"]])
 144 | +        coin = self.wallet.get_utxo()

---

 191 | -        tx_child_b = tx_from_hex(rawtx_b)
 192 | -        tx_child_b.wit.vtxinwit = [CTxInWitness()]
 193 | -        tx_child_b.wit.vtxinwit[0].scriptWitness.stack = [CScript([OP_TRUE])]
 194 | -        tx_child_b_hex = tx_child_b.serialize().hex()
 195 | -        assert not node.testmempoolaccept([tx_child_b_hex])[0]["allowed"]
 196 | +        # # Child B

---

 235 | -                package_hex.append(txhex)
 236 | -                parents_tx.append(tx)
 237 | -                values.append(value)
 238 | -                parent_locking_scripts.append(parent_locking_script)
 239 | -            child_hex = create_child_with_parents(node, self.address, self.privkeys, parents_tx, values, parent_locking_scripts)
 240 | -            # Package accept should work with the parents in any order (as long as parents come before child)

---

 325 |          # Check that each result is present, with the correct size and fees
 326 | -        for i in range(num_parents + 1):
 327 | -            tx = package_txns[i]
 328 | +        for package_tx in package_txns:
 329 | +            tx = package_tx['tx']
 330 |              wtxid = tx.getwtxid()

---

 100 | +                "value": coinbase["vout"][0]["value"],
 101 | +                "scriptPubKey": coinbase["vout"][0]["scriptPubKey"],
 102 | +                "vout": 0,
 103 | +                "height": 0
 104 | +            }
 105 | +        self.generate(node, COINBASE_MATURITY, sync_fun=self.no_op)

---

 289 | @@ -291,6 +290,8 @@ def create_self_transfer_multi(
 290 |                  height=0,
 291 |              ) for i in range(len(tx.vout))],
 292 |              "txid": txid,
 293 | +            "wtxid": tx.getwtxid(),
 294 | +            "vsize": tx.get_vsize(),

---

  59 | +                "value": coinbase["vout"][0]["value"],
  60 |                  "scriptPubKey": coinbase["vout"][0]["scriptPubKey"],
  61 | -            })
  62 | +                "vout": 0,
  63 | +                "height": 0
  64 | +            }

---

 133 |          assert_equal(testres_bad_sig, self.independent_txns_testres + [{
 134 |              "txid": tx_bad_sig.rehash(),
 135 | -            "wtxid": tx_bad_sig.getwtxid(), "allowed": False,
 136 | +            "wtxid": tx_bad_sig.getwtxid(),
 137 | +            "allowed": False,
 138 |              "reject-reason": "mandatory-script-verify-flag-failed (Operation not valid with the current stack size)"

---

 185 |  
 186 |          self.log.info("Testmempoolaccept with entire package, should work with children in either order")
 187 | -        testres_multiple_ab = node.testmempoolaccept(rawtxs=[parent_signed["hex"], tx_child_a_hex, tx_child_b_hex])
 188 | -        testres_multiple_ba = node.testmempoolaccept(rawtxs=[parent_signed["hex"], tx_child_b_hex, tx_child_a_hex])
 189 | +        testres_multiple_ab = node.testmempoolaccept(rawtxs=[parent_tx["hex"], child_a_tx["hex"], child_b_tx["hex"]])
 190 | +        testres_multiple_ba = node.testmempoolaccept(rawtxs=[parent_tx["hex"], child_a_tx["hex"], child_b_tx["hex"]])

---

 307 | +        testres_replaceable = node.testmempoolaccept([replaceable_tx["hex"]])
 308 |          assert_equal(testres_replaceable, [
 309 | -            {"txid": replaceable_tx.rehash(), "wtxid": replaceable_tx.getwtxid(),
 310 | -            "allowed": True, "vsize": replaceable_tx.get_vsize(), "fees": { "base": fee }}
 311 | +            {"txid": replaceable_tx["txid"], "wtxid": replaceable_tx["wtxid"],
 312 | +            "allowed": True, "vsize": replaceable_tx['tx'].get_vsize(), "fees": { "base": fee }}

---

 310 | -            "allowed": True, "vsize": replaceable_tx.get_vsize(), "fees": { "base": fee }}
 311 | +            {"txid": replaceable_tx["txid"], "wtxid": replaceable_tx["wtxid"],
 312 | +            "allowed": True, "vsize": replaceable_tx['tx'].get_vsize(), "fees": { "base": fee }}
 313 |          ])
 314 |  
 315 | -        # Replacement transaction is identical except has double the fee

---

 330 |          ])
 331 |  
 332 |          self.log.info("Test that packages cannot conflict with mempool transactions, even if a valid BIP125 RBF")
 333 | -        node.sendrawtransaction(signed_replaceable_tx["hex"])
 334 | -        testres_rbf_single = node.testmempoolaccept([signed_replacement_tx["hex"]])
 335 | -        # This transaction is a valid BIP125 replace-by-fee

---

 336 | @@ -338,6 +337,19 @@ def sendrawtransaction(self, *, from_node, tx_hex, maxfeerate=0, **kwargs):
 337 |          self.scan_tx(from_node.decoderawtransaction(tx_hex))
 338 |          return txid
 339 |  
 340 | +    def create_self_transfer_chain(self, *, chain_length):

---

 106 |          self.assert_testres_equal(self.independent_txns_hex, self.independent_txns_testres)
 107 |  
 108 |          self.log.info("Test an otherwise valid package with an extra garbage tx appended")
 109 | -        garbage_tx = node.createrawtransaction([{"txid": "00" * 32, "vout": 5}], {self.address: 1})
 110 | +        address = node.get_deterministic_priv_key().address
 111 | +        garbage_tx = node.createrawtransaction([{"txid": "00" * 32, "vout": 5}], {address: 1})

---

 278 | +        testres = node.testmempoolaccept([tx1["hex"], tx1["hex"]])
 279 |          assert_equal(testres, [
 280 | -            {"txid": tx1.rehash(), "wtxid": tx1.getwtxid(), "package-error": "conflict-in-package"},
 281 | -            {"txid": tx1.rehash(), "wtxid": tx1.getwtxid(), "package-error": "conflict-in-package"}
 282 | +            {"txid": tx1["txid"], "wtxid": tx1["wtxid"], "package-error": "conflict-in-package"},
 283 | +            {"txid": tx1["txid"], "wtxid": tx1["wtxid"], "package-error": "conflict-in-package"}

---

 328 |      def test_submit_cpfp(self):
 329 |          node = self.nodes[0]
 330 |          peer = node.add_p2p_connection(P2PTxInvStore())
 331 |  
 332 | -        # 2 parent 1 child CPFP. First parent pays high fees, second parent pays 0 fees and is
 333 | -        # fee-bumped by the child.

---