Their inclusion is likely just the result of copy-paste.
The only place upnp & natpmp CPPFLAGS should be used is libbitcoin_node (mapport.cpp).
build: remove unused cppflags #26089
pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:prune_unneeded_upnp_natpmp changing 2 files +2 −2-
fanquake commented at 10:27 AM on September 14, 2022: member
- fanquake added the label Build system on Sep 14, 2022
-
theuni commented at 7:37 PM on September 14, 2022: member
ACK 557ed5973329052418ad371ebc43a74ac8096f1b. Confirmed that mapport.cpp is the only user of these includes.
From a quick glance it looks like these two shouldn't require libevent either though?
-
hebasto commented at 7:57 PM on September 14, 2022: member
Concept ACK.
Their inclusion is likely just the result of copy-paste.
That is true at least for
NATPMP_CPPFLAGS. -
afce044bb6
build: remove unused natpmp / upnp cppflags
Their inclusion is likely just the result of copy-paste. The only place upnp/natpmpflags should be used is `libbitcoin_node` (mapport.cpp).
-
build: remove unused libevent cppflags 4b656b9ed3
- fanquake renamed this:
build: remove unused natpmp / upnp cppflags
build: remove unused cppflags
on Sep 15, 2022 - fanquake force-pushed on Sep 15, 2022
-
fanquake commented at 8:57 AM on September 15, 2022: member
From a quick glance it looks like these two shouldn't require libevent either though?
Looks like it. Have added a commit to drop them as well.
- theuni approved
-
theuni commented at 1:37 PM on September 15, 2022: member
ACK 4b656b9ed35d502d39ca745047961f242a5d868d
- hebasto approved
-
hebasto commented at 1:38 PM on September 15, 2022: member
ACK 4b656b9ed35d502d39ca745047961f242a5d868d, I have reviewed the code and it looks OK, I agree it can be merged.
- fanquake merged this on Sep 15, 2022
- fanquake closed this on Sep 15, 2022
- fanquake deleted the branch on Sep 15, 2022
- sidhujag referenced this in commit 5667fce568 on Sep 15, 2022
- bitcoin locked this on Sep 15, 2023
Labels