EVENT_*_LIBS are already in LDADD. Move wallet libs into the wallet conditional, similar to zmq.
build: remove duplicate / unneeded libs from bench_bitcoin #26099
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:bench_duplicate_linking changing 1 files +5 −4-
fanquake commented at 9:13 AM on September 15, 2022: member
- fanquake added the label Build system on Sep 15, 2022
-
ff7c81f63a
build: remove duplicate / unneeded libs from bench_bitcoin
EVENT_*_LIBS are already in LDADD. Move wallet libs into the wallet conditional, similar to zmq.
- fanquake force-pushed on Sep 15, 2022
-
DrahtBot commented at 12:04 PM on September 15, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #26008 (wallet: cache IsMine scriptPubKeys to improve performance of wallets with a lot of non-ranged descriptors by achow101)
- #25685 (wallet: Faster transaction creation by removing pre-set-inputs fetching responsibility from Coin Selection by furszy)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
theuni commented at 1:25 PM on September 15, 2022: member
Concept ACK. Definitely more clear.
I guess this only changes anything in the
!ENABLE_WALLETcase? Or am I missing something else?Edit: Sorry, I meant changes the binaries. I see that it'll eliminate the dupe event libs in either case.
-
fanquake commented at 10:01 AM on September 19, 2022: member
I guess this only changes anything in the !ENABLE_WALLET case? Or am I missing something else?
No that looks correct.
- luke-jr approved
-
luke-jr commented at 2:17 PM on September 20, 2022: member
utACK
-
theuni commented at 6:49 PM on September 20, 2022: member
ACK ff7c81f63a25478cfc778c6046d4a7a90eeb3557
- fanquake merged this on Sep 21, 2022
- fanquake closed this on Sep 21, 2022
- fanquake deleted the branch on Sep 21, 2022
- sidhujag referenced this in commit 95581a279b on Sep 23, 2022
- bitcoin locked this on Sep 21, 2023
Labels