doc: clarify that NetPermissionFlags::Implicit is only about whitelists #26100

pull vasild wants to merge 1 commits into bitcoin:master from vasild:netperm_implicit_comment changing 1 files +2 −1

vasild commented at 9:22 AM on September 15, 2022: contributor

NetPermissionFlags::Implicit applies just to connections from -whitebind or -whitelist, clarify that in its comment.
fanquake added the label Docs on Sep 15, 2022
fanquake added the label P2P on Sep 15, 2022
DrahtBot commented at 3:40 AM on September 23, 2022: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK Zero-1729, aureleoules, hernanmarino

Concept ACK vasild



Conflicts

No conflicts as of last run.

Type	Reviewers
ACK	Zero-1729, aureleoules, hernanmarino
Concept ACK	vasild

in src/net_permissions.h:39 in d121024c3d outdated

  34 | @@ -35,7 +35,8 @@ enum class NetPermissionFlags : uint32_t {
  35 |      // unlimited amounts of addrs.
  36 |      Addr = (1U << 7),
  37 |  
  38 | -    // True if the user did not specifically set fine grained permissions
  39 | +    // True if the user did not specifically set fine grained permissions in the
  40 | +    // -whitebind or -whitelist commands.

jonatack commented at 1:41 PM on October 5, 2022:

Concept ACK, the clarification seems worth adding for future readers of the code. Suggest the following improvements to the proposal.

 
-    // True if the user did not specifically set fine grained permissions in the
-    // -whitebind or -whitelist commands.
+    // True if the user did not specifically set fine-grained permissions with
+    // the -whitebind or -whitelist configuration options.

hernanmarino commented at 1:38 PM on October 28, 2022:

vasild commented at 2:22 PM on November 7, 2022:

Done, thanks!

hernanmarino commented at 1:38 PM on October 28, 2022: contributor

ACK d121024c3dce125b45f21d3b4d362b61a9d27d27
Zero-1729 commented at 3:35 AM on November 3, 2022: contributor

Concept ACK

Agree with jonatack's rewording suggestion.
doc: clarify that NetPermissionFlags::Implicit is only about whitelists
Co-authored-by: Jon Atack <jon@atack.com>
f362920c2c
vasild force-pushed on Nov 7, 2022
vasild commented at 2:23 PM on November 7, 2022: contributor

d121024c3d...f362920c2c: address suggestion

Invalidates ACK from @hernanmarino
Zero-1729 commented at 1:45 AM on November 9, 2022: contributor

crACK f362920c2ca85853b24c1cbc1d596dd1ff2fd556
aureleoules approved
aureleoules commented at 5:13 PM on November 21, 2022: member

ACK f362920c2ca85853b24c1cbc1d596dd1ff2fd556
hernanmarino approved
hernanmarino commented at 6:40 PM on November 21, 2022: contributor

re ACK f362920c2ca85853b24c1cbc1d596dd1ff2fd556
maflcko merged this on Nov 22, 2022
maflcko closed this on Nov 22, 2022
vasild deleted the branch on Nov 22, 2022
sidhujag referenced this in commit 40ba118dc0 on Nov 22, 2022
bitcoin locked this on Nov 22, 2023

Contributors

Labels

doc: clarify that NetPermissionFlags::Implicit is only about whitelists #26100

Reviews

Conflicts