log: Use steady clock for bench logging #26118

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2209-ci-t-🎎 changing 5 files +111 −58

maflcko commented at 9:35 AM on September 19, 2022: member

Instead of using 0.001 and similar constants to "convert" an int64_t to milliseconds, use the type-safe Ticks<> helper. Also, use steady clock instead of system clock, since the durations are used for benchmarking.

scripted-diff: Rename time symbols

-BEGIN VERIFY SCRIPT-

 ren() { sed -i "s:\<$1\>:$2:g" $(git grep -l "\<$1\>" ':(exclude)src/versionbits.cpp') ; }

 ren nStart                 time_start
 ren nTimeStart             time_start
 ren nTimeReadFromDiskTotal time_read_from_disk_total
 ren nTimeConnectTotal      time_connect_total
 ren nTimeFlush             time_flush
 ren nTimeChainState        time_chainstate
 ren nTimePostConnect       time_post_connect
 ren nTimeCheck             time_check
 ren nTimeForks             time_forks
 ren nTimeConnect           time_connect
 ren nTimeVerify            time_verify
 ren nTimeUndo              time_undo
 ren nTimeIndex             time_index
 ren nTimeTotal             time_total
 ren nTime1                 time_1
 ren nTime2                 time_2
 ren nTime3                 time_3
 ren nTime4                 time_4
 ren nTime5                 time_5
 ren nTime6                 time_6

 ren nBlocksTotal num_blocks_total

 # Newline after semicolon
 perl -0777 -pi -e 's/; time_connect_total/;\n        time_connect_total/g' src/validation.cpp
 perl -0777 -pi -e 's/; time_/;\n    time_/g'                               src/validation.cpp

-END VERIFY SCRIPT-

faed342a23

fanquake added the label Utils/log/libs on Sep 19, 2022
fanquake commented at 9:40 AM on September 19, 2022: member

Concept ACK
Use steady clock for bench logging fabf1cdb20
maflcko force-pushed on Sep 19, 2022
DrahtBot commented at 6:48 PM on September 19, 2022: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #25830 (refactor: Replace m_params with chainman.GetParams() by aureleoules)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
jarolrod commented at 1:48 PM on September 20, 2022: member

concept ack
fanquake approved
fanquake commented at 4:02 PM on October 3, 2022: member

ACK fabf1cdb206e368a9433abf99a5ea2762a5ed2c0 - validation bench output still looks sane.
maflcko merged this on Oct 10, 2022
maflcko closed this on Oct 10, 2022
maflcko deleted the branch on Oct 10, 2022
sidhujag referenced this in commit cb23060737 on Oct 10, 2022
bitcoin locked this on Oct 10, 2023

Contributors

Labels

log: Use steady clock for bench logging #26118

Conflicts