build: remove strings.h from header checks #26135

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_strings_h changing 2 files +1 −4

fanquake commented at 11:25 AM on September 20, 2022: member

We don't include strings.h anywhere.

This is also already checked for by autoconf, so us checking for it just means a 3rd existence check during ./configure.

build: remove strings.h from header checks

We don't include strings.h anywhere.

This is also already checked for by autoconf, so us checking for it just
means a 3rd existence check during ./configure.

eb6026b90f

fanquake added the label Build system on Sep 20, 2022
TheCharlatan approved
TheCharlatan commented at 11:33 AM on September 21, 2022: contributor

Code review ACK eb6026b90ff6a40a8802be3fc00cdda1c780fd95

Indeed, strings.h is unused and is checked (excluded) in AC_INCLUDES_DEFAULT
hebasto approved

hebasto commented at 2:26 PM on September 21, 2022: member

ACK eb6026b90ff6a40a8802be3fc00cdda1c780fd95, tested on macOS 12.6:

on master 80d159813306fa4137afd35e280e14568bf94f0e:

% ./autogen.sh
% ./configure 2>&1 | grep -e 'strings.h'
checking for strings.h... yes
checking for strings.h... (cached) yes
checking for strings.h... yes

with this PR:

% ./autogen.sh
% ./configure 2>&1 | grep -e 'strings.h'       
checking for strings.h... yes
checking for strings.h... yes

fanquake merged this on Sep 21, 2022
fanquake closed this on Sep 21, 2022
fanquake deleted the branch on Sep 21, 2022
sidhujag referenced this in commit c8e57cd63e on Sep 23, 2022
bitcoin locked this on Sep 21, 2023

Contributors

Labels