build: Remove `stdlib.h` from header checks #26159

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:remove_stdlib_h_configure changing 23 files +24 −25

fanquake commented at 10:34 AM on September 23, 2022: member

We already use a mix of <cstlib> and stdlib.h unconditionally throughout the codebase.

Us checking this header also duplicates work already done by autotools. Currently stdlib.h is checked for 3 times during a ./configure run, after this change, at least it's only twice.

Similar to #26150.

refactor: use <cstdlib> over stdlib.h

We currently use both. Consolidate on the former.

a63d4cb26a

build: remove stdlib.h from header checks

We already use a mix of <cstdlib> and stdlib.h unconditionally throughout
the codebase.

Us checking this header also duplicates work already done by autotools.
Currently stdlib.h is checked for 3 times during a ./configure run, after
this change, at least it's only twice.

553ff452c0

fanquake added the label Build system on Sep 23, 2022
fanquake requested review from TheCharlatan on Sep 23, 2022
kristapsk approved
kristapsk commented at 1:17 PM on September 23, 2022: contributor

ACK 553ff452c0e95a9647d35f10f67e45f24bd2d9b7
in src/script/miniscript.h:17 in 553ff452c0
```
  12 | @@ -13,8 +13,8 @@
  13 |  #include <string>
  14 |  #include <vector>
  15 |  
  16 | -#include <stdlib.h>
  17 |  #include <assert.h>
  18 | +#include <cstdlib>
```
MarcoFalke commented at 3:00 PM on September 23, 2022:

You'll have to do this upstream as well?

fanquake commented at 3:18 PM on September 23, 2022:

Opened a change upstream: https://github.com/sipa/miniscript/pull/124.
fanquake referenced this in commit 914bc2ca01 on Sep 23, 2022
fanquake referenced this in commit e67df70213 on Sep 24, 2022
DrahtBot commented at 4:31 PM on September 24, 2022: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #25361 (BIP324: Cipher suite by dhruv)
- #23561 (BIP324: Handshake prerequisites by dhruv)
- #23233 (BIP324: Add encrypted p2p transport {de}serializer by dhruv)
- #19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
TheCharlatan approved
TheCharlatan commented at 10:54 AM on September 25, 2022: contributor

ACK 553ff452c0e95a9647d35f10f67e45f24bd2d9b7
MarcoFalke merged this on Sep 25, 2022
MarcoFalke closed this on Sep 25, 2022
fanquake deleted the branch on Sep 25, 2022
bitcoin locked this on Sep 25, 2023

Contributors

Labels

Linked (view graph)

#26150 build: remove stdio.h from header checks

build: Remove `stdlib.h` from header checks #26159

Conflicts