Opening macOS DMG does not open Finder window #26176

1. 
   prusnak commented at 3:30 PM on September 24, 2022: contributor

   When I open bitcoin-24.0rc1-arm64-apple-darwin.dmg the volume is mounted silently, but does not open Finder window leading to very confusing user experience.

   OS: macOS 12.6 (21G115) on MacBook Air (M1, 2020)

   This is a regression from bitcoin-23.0-arm64-apple-darwin.dmg which opens the following Finder window:

   <img width="527" alt="Screenshot 2022-09-24 at 17 31 58" src="https://user-images.githubusercontent.com/42201/192106347-7f738f20-f80f-4f74-aca0-7cbde2146e3a.png">

   PS: I downloaded the file from https://bitcoincore.org/bin/bitcoin-core-24.0/test.rc1/bitcoin-24.0rc1-arm64-apple-darwin.dmg

2. prusnak added the label Bug on Sep 24, 2022
3. fanquake added the label macOS on Sep 24, 2022
4. 
   fanquake commented at 3:55 PM on September 24, 2022: member

   This is a side-effect of #24031. We removed the compression step from the macOS DMG creation, to further slim down our macOS toolchain, and by removing dmg, made it possible to have cross-architecture builds for the macOS HOSTS (including the native dmg tool would have prevented this). However not compressing resulted in a release dmg that, iirc, didn't have a certain header bit set, which meant that on-mount, the Finder window wouldn't popup as it previously would have.

   It was thought that this shouldn't be too much of an issue, as the DMG still mounts, and it's just a case of picking it from Finder, however I wonder if there's a way we can retain the same functionality. I'll take a look.

5. 
   Sjors commented at 8:07 AM on September 28, 2022: member

   When opening my own Guix build, I found it more confusing than I expected. But that's partly because I disabled putting mounted volumes on my desktop.

6. 
   prusnak commented at 8:46 AM on September 28, 2022: contributor

   But that's partly because I disabled putting mounted volumes on my desktop.

   I never see my desktop since I have always fullscreen windows open. So it's confusing even if you don't disable this feature.

7. 
   prusnak commented at 3:13 PM on November 5, 2022: contributor

   still present with 24.0rc3

8. maflcko added this to the milestone 24.0 on Nov 5, 2022
9. fanquake removed this from the milestone 24.0 on Nov 17, 2022
10. fanquake added this to the milestone 24.1 on Nov 17, 2022
11. 
    fanquake commented at 2:08 PM on November 17, 2022: member

    Moved this to 24.1, although I'm not sure this is going to be solved. It might be time to re-propose distributing the macOS binaries in a .tar like all others.

12. 
    prusnak commented at 2:15 PM on November 17, 2022: contributor

    It might be time to re-propose distributing the macOS binaries in a .tar like all others.

    Yes, this might be the best solution. I've seen software distributing just a ZIP instead of a DMG. (VSCode is one example). So people are probably starting to get used to this?

13. fanquake removed this from the milestone 24.1 on Mar 12, 2023
14. fanquake added this to the milestone 25.0 on Mar 12, 2023
15. 
    fanquake commented at 4:41 PM on March 12, 2023: member

    Moving this to 25.x. See one potential fix in #27099.

16. 
    fanquake commented at 11:36 AM on April 15, 2023: member

    #27099 isn't going to get in before branch-off, so moving this to 26.x.

17. fanquake removed this from the milestone 25.0 on Apr 15, 2023
18. fanquake added this to the milestone 26.0 on Apr 15, 2023
19. fanquake renamed this:
    Opening bitcoin-24.0rc1-arm64-apple-darwin.dmg does not open Finder window
    Opening macOS DMG does not open Finder window
    on Apr 15, 2023
20. 
    maflcko commented at 11:27 AM on September 5, 2023: member

    I think the milestone can be removed, given that #27099 is stale and this is not a regression from the previous release.

21. 
    Sjors commented at 3:12 PM on September 5, 2023: member

    I just got another force push and I'm running a guix build for it. Would be nice to get it over with, so the next release download is less confusing, but agree it's not release blocking.

22. fanquake referenced this in commit e9a4793b82 on Sep 20, 2023
23. 
    maflcko commented at 11:30 AM on September 21, 2023: member

    Closing for now after #28432. Leave a comment if this should be reopened or if there is still something to be done.

24. maflcko closed this on Sep 21, 2023

    ---

25. bitcoin locked this on Sep 20, 2024

Contributors

prusnakfanquakeSjorsmaflcko

Milestone
26.0