test: Use proper Boost macros instead of assertions #26229

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:221002-testban changing 1 files +2 −2

hebasto commented at 11:07 PM on October 2, 2022: member

On the master branch:

$ src/test/test_bitcoin -l test_suite -t banman_tests
Running 1 test case...
...
Test case banman_tests/file did not check any assertions
...

This PR suggests to use proper Boost macros.

test: Use proper Boost macros instead of assertions 5c9a27a46f
hebasto added the label Tests on Oct 2, 2022
hebasto commented at 11:08 PM on October 2, 2022: member

ping @MarcoFalke as an author of the test.
fanquake commented at 8:35 AM on October 3, 2022: member

This seems fine, but we also currently use a mixture of assert() and BOOST() macros throughout multiple other unit tests.
MarcoFalke merged this on Oct 3, 2022
MarcoFalke closed this on Oct 3, 2022
hebasto deleted the branch on Oct 3, 2022
sidhujag referenced this in commit 10e5255a49 on Oct 4, 2022
bitcoin locked this on Oct 3, 2023

Contributors

Labels