refactor: move *index constants out of validation #26235

pull fanquake wants to merge 3 commits into bitcoin:master from fanquake:move_index_from_val changing 5 files +7 −4

fanquake commented at 3:04 PM on October 3, 2022: member

Move *index default constants out of validation.h.

in src/node/caches.cpp:10 in 3521e630bf outdated

   3 | @@ -4,6 +4,7 @@
   4 |  
   5 |  #include <node/caches.h>
   6 |  
   7 | +#include <index/txindex.h>
   8 |  #include <txdb.h>
   9 |  #include <util/system.h>
  10 |  #include <validation.h>

stickies-v commented at 4:58 PM on October 3, 2022:

No more need for validation.h

fanquake commented at 5:21 PM on October 3, 2022:

Dropped.

DrahtBot added the label Refactoring on Oct 3, 2022
stickies-v approved
stickies-v commented at 5:04 PM on October 3, 2022: contributor

ACK 3521e630b - more sensible place for these constants to live
refactor: move DEFAULT_TXINDEX from validation to txindex 2bfc1e6aaa
refactor: move DEFAULT_COINSTATSINDEX from validation to coinstatsindex c87d569189
refactor: move DEFAULT_BLOCKFILTERINDEX from val to blockfilterindex 7d14577d0f
fanquake force-pushed on Oct 3, 2022
stickies-v commented at 5:24 PM on October 3, 2022: contributor

re-ACK 7d14577d0f9316feef3bcb5220aa3037748615d3
DrahtBot commented at 11:40 PM on October 3, 2022: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #25704 (refactor: Remove almost all validation option globals by MarcoFalke)
- #24897 ([Draft / POC] Silent Payments by w0xlt)
- #24539 (Add a "tx output spender" index by sstone)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
aureleoules approved
aureleoules commented at 7:08 AM on October 4, 2022: member

ACK 7d14577d0f9316feef3bcb5220aa3037748615d3
maflcko merged this on Oct 4, 2022
maflcko closed this on Oct 4, 2022
fanquake deleted the branch on Oct 4, 2022
sidhujag referenced this in commit 06d3f5426b on Oct 4, 2022
bitcoin locked this on Nov 8, 2023

Contributors

Labels

refactor: move *index constants out of validation #26235

Conflicts