test: Remove unused fCheckpointsEnabled from miner_tests #26243

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2210-test-checkpoints-🏎 changing 1 files +0 −4

MarcoFalke commented at 10:42 AM on October 4, 2022: member

The earliest checkpoint is at height 11111, so this can't possibly have any impact on this test.

test: Remove unused fCheckpointsEnabled from miner_tests

The earliest checkpoint is at height 11111, so this can't possibly have
any impact on this test.

fa9436e908

fanquake added the label Tests on Oct 4, 2022
fanquake requested review from glozow on Oct 4, 2022
fanquake approved
fanquake commented at 11:37 AM on October 4, 2022: member

ACK fa9436e90859c31d9aa7bc0b7f223ab93ec14bdc - given the low number of blocks, having the additional check in ContextualCheckBlockHeader() enabled should be a no-op, so disabling and re-enabling is dead code.

Note that pcheckpoint is a nullptr in any case, so we'll also never drop into the nHeight < pcheckpoint->nHeight logic.
glozow commented at 11:38 AM on October 4, 2022: member

ACK
DrahtBot commented at 1:42 PM on October 4, 2022: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #25073 (test: Cleanup miner_tests by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake merged this on Oct 4, 2022
fanquake closed this on Oct 4, 2022
MarcoFalke deleted the branch on Oct 5, 2022
sidhujag referenced this in commit 5572370e0b on Oct 5, 2022
bitcoin locked this on Oct 5, 2023

Contributors

Labels