build, msvc: Enable C4834 warning #26244

1. 
   hebasto commented at 11:06 am on October 4, 2022: member

   Since bitcoin/bitcoin#26189 our codebase is C4834 warning free.

   See https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c4834.

2. build, msvc: Enable C4834 warning

   https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c4834

   f3e40c481a
3. fanquake requested review from sipsorcery on Oct 4, 2022
4. fanquake added the label Windows on Oct 4, 2022
5. 
   hebasto commented at 12:59 pm on October 4, 2022: member

   Friendly ping @sipsorcery.
6. 
   DrahtBot commented at 1:40 pm on October 4, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #26252 (refactor: Make 64-bit shift explicit by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. sipsorcery approved
8. 
   sipsorcery commented at 7:19 pm on October 4, 2022: member

   tACK f3e40c481ad77c9664198d4ad89c2fc4e6bfc10f.
9. fanquake merged this on Oct 4, 2022
10. fanquake closed this on Oct 4, 2022

    ---

11. hebasto deleted the branch on Oct 4, 2022
12. sidhujag referenced this in commit 012f9a05f1 on Oct 5, 2022
13. bitcoin locked this on Oct 4, 2023

Contributors
hebasto DrahtBot sipsorcery

Labels
Windows