Since bitcoin/bitcoin#26189 our codebase is C4834 warning free.
See https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c4834.
build, msvc: Enable C4834 warning #26244
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:221004-msvc changing 1 files +1 −1-
hebasto commented at 11:06 AM on October 4, 2022: member
-
f3e40c481a
build, msvc: Enable C4834 warning
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c4834
- fanquake requested review from sipsorcery on Oct 4, 2022
- fanquake added the label Windows on Oct 4, 2022
-
hebasto commented at 12:59 PM on October 4, 2022: member
Friendly ping @sipsorcery.
-
DrahtBot commented at 1:40 PM on October 4, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #26252 (refactor: Make 64-bit shift explicit by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- sipsorcery approved
-
sipsorcery commented at 7:19 PM on October 4, 2022: member
tACK f3e40c481ad77c9664198d4ad89c2fc4e6bfc10f.
- fanquake merged this on Oct 4, 2022
- fanquake closed this on Oct 4, 2022
- hebasto deleted the branch on Oct 4, 2022
- sidhujag referenced this in commit 012f9a05f1 on Oct 5, 2022
- bitcoin locked this on Oct 4, 2023
Contributors
Labels