refactor: Use type-safe time point for CWallet::m_next_resend #26302

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2210-wallet-time-🤗 changing 2 files +5 −4

maflcko commented at 12:52 PM on October 13, 2022: member

GetTime is not type-safe, thus deprecated, see https://github.com/bitcoin/bitcoin/blob/75cbbfa279685f70d9f6fa71432df00862ffa865/src/util/time.h#L62-L70
refactor: Use type-safe time point for CWallet::m_next_resend fa51cc9651
DrahtBot added the label Refactoring on Oct 13, 2022
shaavan approved
shaavan commented at 2:57 PM on October 13, 2022: contributor

Code Review ACK fa51cc965110e14661c848364a29c493287673be

Verified that the GetTime is deprecated. And NodeClock::time_point is correctly used in replacing it in GetDefaultNextResend function.
DrahtBot commented at 10:06 PM on October 13, 2022: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
dergoegge commented at 9:49 AM on October 19, 2022: member

Concept ACK
aureleoules approved
aureleoules commented at 10:25 AM on October 19, 2022: member

ACK fa51cc965110e14661c848364a29c493287673be
fanquake merged this on Oct 24, 2022
fanquake closed this on Oct 24, 2022
maflcko deleted the branch on Oct 24, 2022
sidhujag referenced this in commit 125bf5cb09 on Oct 25, 2022
bitcoin locked this on Oct 24, 2023

Contributors

Labels