add lock annotation for FeeFilterRounder::round() #26306

pull glozow wants to merge 1 commits into bitcoin:master from glozow:2022-10-round-mutex changing 2 files +2 −1
  1. glozow commented at 6:43 pm on October 13, 2022: member

    CI failure from #24407: https://github.com/bitcoin/bitcoin/runs/8876014446

    Calling WITH_LOCK() on a non-recursive mutex requires not holding it beforehand.

  2. add lock annotation for FeeFilterRounder::round()
    Calling WITH_LOCK() on a non-recursive mutex requires not holding it beforehand.
    
    Co-authored-by: Niklas Gögge <n.goeggi@gmail.com>
    cbb2da8fcf
  3. glozow added the label Bug on Oct 13, 2022
  4. achow101 commented at 6:46 pm on October 13, 2022: member

    ACK cbb2da8fcf0c81453695c4ec8ce6c467e6a5c8ba

    Works correctly locally, waiting for CI.

  5. dergoegge commented at 6:53 pm on October 13, 2022: member
    ACK cbb2da8fcf0c81453695c4ec8ce6c467e6a5c8ba
  6. hebasto approved
  7. hebasto commented at 7:58 pm on October 13, 2022: member
    ACK cbb2da8fcf0c81453695c4ec8ce6c467e6a5c8ba, tested on Ubuntu 22.04 with clang 14.0.
  8. achow101 merged this on Oct 13, 2022
  9. achow101 closed this on Oct 13, 2022

  10. vasild commented at 7:02 am on October 14, 2022: contributor
    ACK cbb2da8fcf0c81453695c4ec8ce6c467e6a5c8ba
  11. sidhujag referenced this in commit 867554743b on Oct 23, 2022
  12. bitcoin locked this on Oct 14, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me