[24.x] Revert "build: Use Homebrew's sqlite package if it is available" #26327

1. 
   maflcko commented at 3:36 PM on October 17, 2022: member

   Identical commit, taken as-is from https://github.com/bitcoin/bitcoin/pull/25985

2. Revert "build: Use Homebrew's sqlite package if it is available"

   This reverts ee7b84e63cbeadd5e680d69ff0548275581e9241 from #20527.
   This change was made without any rationale, maybe other than a brew
   installed version might be newer, and that's "better". However when
   building from source on macOS, it just results in drastically worse
   perofrmance, and results in issues / confusions like #25724.
   
   Resolves the "build from source" portion of #25724. Building from
   depends is still not ideal, however I have some other changes that might
   help improve things in that case.
   
   The difference in performance can be observed using the example from
   https://github.com/bitcoin/bitcoin/issues/25724#issuecomment-1213554922,
   but minified to only 10 descriptors. i.e:
   ```bash
   time src/bitcoin-cli createwallet speedy true
   time src/bitcoin-cli importdescriptors '[
     {"desc":"raw(00145846369f3d6ba366d6f5a903fb5cf4dca3763c0e)#k9wh6v62","timestamp":"now"},
     {"desc":"raw(001420800aabf13f3a4c4ce3ce4c66cecf1d17f21a6e)#6m0hlfh4","timestamp":"now"},
     {"desc":"raw(0014c6bf9715e06d73ebf9b3b02d5cc48d24d8bbabc1)#wyavh36r","timestamp":"now"},
     {"desc":"raw(00141ba7807b3f46af113beaea5c698428ce7138cd8a)#jctdsups","timestamp":"now"},
     {"desc":"raw(00140c1bd27f10fff01b36ddf3c1febaa1acff19b080)#9s6nc3pk","timestamp":"now"},
     {"desc":"raw(00141226e31987e4bc2e63c0ee12908f675e40464b20)#9pp7qm39","timestamp":"now"},
     {"desc":"raw(0014f73f149f7503960a5e849c6ee7a8a8c336f631cb)#qtkxv9fc","timestamp":"now"},
     {"desc":"raw(0014c8ccb4d81ffc769fc5fdd8d7eed69b0e0cae5749)#hn39qayv","timestamp":"now"},
     {"desc":"raw(001498565aead2d67a22a6021d55210f2a917fc22169)#6ar3vwsx","timestamp":"now"},
     {"desc":"raw(001403013248ac0cd9eabe176cad162cda2a19f771e1)#4m47mukd","timestamp":"now"}
   ]'
   ```
   
   Running master, when building from souce and using brew installed
   sqlite, this takes ~3.4s. With this PR, the same operation takes ~0.3s.

   d216d714aa
3. DrahtBot added the label Backport on Oct 17, 2022
4. 
   dergoegge commented at 4:23 PM on October 17, 2022: member

   ACK d216d714aae36e6f1c95f82aef81a0be74dee2f3

5. hebasto approved
6. 
   hebasto commented at 6:32 PM on October 17, 2022: member

   ACK d216d714aae36e6f1c95f82aef81a0be74dee2f3

   nit: no usual commit message backport stuff like

   Github-Pull: ...
   Rebased-From: ...
   

   ?

7. fanquake added this to the milestone 24.0 on Oct 18, 2022
8. 
   maflcko commented at 6:39 AM on October 18, 2022: member

   Yes, it was written before the branch-off, so it can just be merged like any other commit before the branch-off. Just seems extra effort to change the commit id, add metadata, and then ask reviewers to verify the metadata again for no reason?

9. 
   hebasto commented at 6:42 AM on October 18, 2022: member

   Yes, it was written before the branch-off, so it can just be merged like any other commit before the branch-off.

   Right.

10. fanquake merged this on Oct 18, 2022
11. fanquake closed this on Oct 18, 2022

    ---

12. fanquake deleted the branch on Oct 18, 2022
13. bitcoin locked this on Oct 18, 2023

Milestone
24.0