ci: Use `macos-ventura-xcode:14.1` image for "macOS native" task #26388

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:221025-ventura changing 3 files +7 −8

hebasto commented at 10:50 AM on October 25, 2022: member

The "macOS native" CI task always uses the recent OS image.

This PR updates it up to the recent macOS release.

Cirrus Labs stopped updating macOS images for x86_64, therefore, an arm64 image been used.

Also make test-security-check has been dropped as it "isn't even expected to pass" on arm64 in CI.
ci: Make `getopt` path architecture agnostic 702836530f
hebasto added the label macOS on Oct 25, 2022
hebasto added the label Tests on Oct 25, 2022
hebasto renamed this:
~~ci: Use macos-ventura-xcode:14.1 image for "macOS native" task~~
ci: Use `macos-ventura-xcode:14.1` image for "macOS native" task
on Oct 25, 2022
in .cirrus.yml:315 in 1d45cc39f7 outdated
```
 311 | @@ -312,16 +312,16 @@ task:
 312 |      FILE_ENV: "./ci/test/00_setup_env_mac.sh"
 313 |  
 314 |  task:
 315 | -  name: 'macOS 12 native x86_64 [gui, system sqlite] [no depends]'
 316 | +  name: 'macOS 13 native arm64 [gui] [no depends]'
```
maflcko commented at 11:03 AM on October 25, 2022:

Is this no longer using sqlite? I think we should have one task that runs sqlite-only

hebasto commented at 11:17 AM on October 25, 2022:

Using system sqlite package is by default on macOS since #25985.

maflcko commented at 11:30 AM on October 25, 2022:

Well, it should mention that this is sqlite-only (no bdb). But it looks like you removed the "only" in 0bb7a1f71db1d986ab824d114534fb7671024990 ?

hebasto commented at 12:26 PM on October 25, 2022:

Well, it should mention that this is sqlite-only (no bdb).

Maybe install berkeley-db@4 package?

maflcko commented at 12:36 PM on October 25, 2022:

No, the goal is to not have bdb, so that sqlite-only (test) bugs are detected

hebasto commented at 12:40 PM on October 25, 2022:

Updated.
fanquake commented at 11:06 AM on October 25, 2022: member

Also make test-security-check has been dropped as it "isn't even expected to pass" on arm64.

Yes it is expected to pass; in a Guix build. Not in the randomly bumped / changed CI environment.
ci: Use `macos-ventura-xcode:14.1` image for "macOS native" task da16893474
hebasto force-pushed on Oct 25, 2022
maflcko approved
maflcko commented at 12:41 PM on October 25, 2022: member

lgtm
Sjors commented at 2:01 PM on October 27, 2022: member

Also make test-security-check has been dropped as it "isn't even expected to pass" on arm64 in CI.

Could be worth pointing to that issue in the commit message.

utACK da16893

Tangentially related: I'm able to build and run the tests on an Intel mac after updating to Ventura 13.0. Surprisingly :-)
maflcko merged this on Oct 27, 2022
maflcko closed this on Oct 27, 2022
hebasto deleted the branch on Oct 28, 2022
sidhujag referenced this in commit d8f554176c on Oct 28, 2022
sidhujag referenced this in commit 49b99c68f1 on Oct 30, 2022
fanquake referenced this in commit b59b289d6f on Jan 12, 2023
fanquake referenced this in commit 020086443f on Jan 12, 2023
fanquake referenced this in commit 9ac5d4a981 on Jan 12, 2023
maflcko referenced this in commit 50ad39d9d0 on Jan 12, 2023
maflcko referenced this in commit 95ec9604a4 on Jan 12, 2023
fanquake referenced this in commit 8f2e58fbbf on Jan 12, 2023
fanquake referenced this in commit 5d7bac319d on Jan 12, 2023
jarolrod referenced this in commit 4f0b233f21 on Jan 13, 2023
fanquake referenced this in commit 3bbcbf243a on Jan 13, 2023
fanquake referenced this in commit 72c8d37ba5 on Jan 13, 2023
fanquake referenced this in commit 53fd827883 on Jan 16, 2023
fanquake referenced this in commit a3db8bd7ca on Jan 16, 2023
theuni commented at 11:30 PM on May 16, 2023: member

As seen here, this seems to have removed RUN_SECURITY_TESTS for x86 too? Ping @hebasto
fanquake commented at 10:02 AM on May 17, 2023: member

As #27676 (comment), this seems to have removed RUN_SECURITY_TESTS for x86 too?

See #27683.
fanquake referenced this in commit 681ecac5c2 on Jun 14, 2023
sidhujag referenced this in commit b391c9fea3 on Jun 15, 2023
supernormand referenced this in commit d165294541 on Jul 10, 2023
achow101 referenced this in commit b97b05048d on Aug 15, 2023
bitcoin locked this on May 16, 2024

Contributors

Labels

Linked (view graph)

#25160 ci: Add "macOS 12 native arm64" task #26386 test: `make test-security-check` fails on macOS arm64 #27881 ci: Use latest `macos-ventura-xcode:14.3.1` image #28187 ci: Run "macOS native x86_64" job on GitHub Actions