[24.x] rc3 backports #26410

1. 
   fanquake commented at 10:09 am on October 28, 2022: member

   Backports:

   • #26321
   • #26344
   • #26275
   • #26349
2. Adjust `.tx/config` for new Transifex CLI

   The old Transifex Command-Line Tool is considered deprecated (as of
   January 2022) and will sunset on Nov 30, 2022.
   
   See: https://github.com/transifex/cli/blob/devel/README.md#migrating-from-older-versions-of-the-client
   
   An accompanying PR: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/142
   
   Github-Pull: #26321
   Rebased-From: d6adbb7ee1de661ad89879609eecd11129322405

   4b7d30d026
3. wallet: Correctly check ismine for sendall

   sendall should be using a bitwise AND for sendall's IsMine check rather
   than an equality as IsMine will never return ISMINE_ALL.
   
   Github-Pull: #26344
   Rebased-From: 6bcd7e2a3b52f855db84cd23b5ee70d27be3434f

   bbe864a13a
4. test: Test that sendall works with watchonly spending specific utxos

   Github-Pull: #26344
   Rebased-From: 708b72b7151c855cb5dac2fb6a81e8f35153c46f

   931db785ee
5. wallet: Check utxo prevout index out of bounds in sendall

   Github-Pull: #26344
   Rebased-From: b132c85650afb2182f2e58e903f3d6f86fd3fb22

   dedee6af57
6. test: Test for out of bounds vout in sendall

   Github-Pull: #26344
   Rebased-From: 315fd4dbabb6b631b755811742a3bdf93e1241bf

   b04f5f9608
7. rpc: fix crash in deriveaddresses when derivation index is 2147483647

   2147483647 is the maximum positive value of a signed int32, and - currently -
   the maximum value that the deriveaddresses bitcoin RPC call accepts as
   derivation index due to its input validation routines.
   
   Before this change, when the derivation index (and thus range_end) reached
   std::numeric_limits<int_32_t>::max(), the "i" variable in the for cycle (which
   is declared as int, and as such 32 bits in size on most platforms) would be
   incremented at the end of the first iteration and then warp back to
   -2147483648. This caused SIGABRT in bitcoind and a core dump.
   
   This change assigns "i" an explicit size of 64 bits on every platform,
   sidestepping the problem.
   
   Fixes #26274.
   
   Github-Pull: #26275
   Rebased-From: addf9d6502db12cebcc5976df3111cac1a369b82

   bf2bf73bcb
8. rpc: add non-regression test about deriveaddresses crash when index is 2147483647

   This test would cause a crash in bitcoind (see #26274) if the fix given in the
   previous commit was not applied.
   
   Github-Pull: #26275
   Rebased-From: 9153ff3e274953ea0d92d53ddab4c72deeace1b1

   e4b8c9b2bf
9. rpc: make `address` field optional

   Github-Pull: #26349
   Rebased-From: eb679a7896ce00e322972a011b023661766923b9

   d5701900fc
10. fanquake added the label Backport on Oct 28, 2022
11. fanquake added this to the milestone 24.0 on Oct 28, 2022
12. hebasto approved
13. 
    hebasto commented at 10:30 am on October 28, 2022: member

    ACK d5701900fcf70220701a1686588114db165dce1c, I’ve cherry-picked commits manually and got zero diff with this PR branch.
14. fanquake requested review from instagibbs on Oct 28, 2022
15. 
    instagibbs commented at 1:22 pm on October 28, 2022: member

    ACK https://github.com/bitcoin/bitcoin/pull/26410/commits/d5701900fcf70220701a1686588114db165dce1c

    applied locally to 24.x, diff matches

16. fanquake merged this on Oct 31, 2022
17. fanquake closed this on Oct 31, 2022

    ---

18. fanquake deleted the branch on Oct 31, 2022
19. bitcoin locked this on Oct 31, 2023

Contributors
fanquake hebasto instagibbs

Review Requested
instagibbs

Labels
Backport

Milestone
24.0