[23.1] Backports #26411

1. 
   fanquake commented at 10:21 am on October 28, 2022: member

   Backports:

   • #26275
   • #26321

   Will leave open to collect remaining backports before a 23.1.

2. Adjust `.tx/config` for new Transifex CLI

   The old Transifex Command-Line Tool is considered deprecated (as of
   January 2022) and will sunset on Nov 30, 2022.
   
   See: https://github.com/transifex/cli/blob/devel/README.md#migrating-from-older-versions-of-the-client
   
   An accompanying PR: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/142
   
   Github-Pull: #26321
   Rebased-From: d6adbb7ee1de661ad89879609eecd11129322405

   bbea830a96
3. rpc: fix crash in deriveaddresses when derivation index is 2147483647

   2147483647 is the maximum positive value of a signed int32, and - currently -
   the maximum value that the deriveaddresses bitcoin RPC call accepts as
   derivation index due to its input validation routines.
   
   Before this change, when the derivation index (and thus range_end) reached
   std::numeric_limits<int_32_t>::max(), the "i" variable in the for cycle (which
   is declared as int, and as such 32 bits in size on most platforms) would be
   incremented at the end of the first iteration and then warp back to
   -2147483648. This caused SIGABRT in bitcoind and a core dump.
   
   This change assigns "i" an explicit size of 64 bits on every platform,
   sidestepping the problem.
   
   Fixes #26274.
   
   Github-Pull: #26275
   Rebased-From: addf9d6502db12cebcc5976df3111cac1a369b82

   d9f1c89e49
4. rpc: add non-regression test about deriveaddresses crash when index is 2147483647

   This test would cause a crash in bitcoind (see #26274) if the fix given in the
   previous commit was not applied.
   
   Github-Pull: #26275
   Rebased-From: 9153ff3e274953ea0d92d53ddab4c72deeace1b1

   f8ed34d1a9
5. fanquake added the label Backport on Oct 28, 2022
6. fanquake added this to the milestone 23.1 on Oct 28, 2022
7. 
   maflcko commented at 3:48 pm on October 31, 2022: member

   cherry-pick ACK f8ed34d1a9faf373b96842c26a408b039bcdfc51 🚝

   Signature:

    0-----BEGIN PGP SIGNED MESSAGE-----
    1Hash: SHA512
    2
    3cherry-pick ACK f8ed34d1a9faf373b96842c26a408b039bcdfc51  🚝
    4-----BEGIN PGP SIGNATURE-----
    5
    6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    7pUh4fQv/fqqWkBogNFKJx+rm5sISNZhhvUVNaTh5PLT/JvCQciZvs2AHroVv5WLm
    8N4RgaZjZuLaBCIlZlhi+ROJpAP3NaaCK32UFSyO46iQovjOCWoPvxAkB/Dua/hLO
    9xwjsCST59odgr34mfO89zmdMSDZwYJ0tqqfqzO/kKRhnCvswwjyAhqqQk0rhD3ys
   10nGuqYHuv4Ahucu8H/HxIRXCWVVJbkAyIaruJKcj5rogUCHIF2f3dfDJYfP4rgYjm
   11ILyZByeOJKZXtdmm9X0cDsnShZX9Fa/XffXM60iGJ0DockxBKVCgbgq6V3XnbgD+
   12hppcslBAXz8ueFWVqIDRL1H3xmTg+Ifcm7l3dU4e+1Wm5Fd7CYHb9L9kwdZdEcvs
   13oRR9wqO/ARCYOhoIIK4vhcvAUYt61lubdkagI8kZy3tzFty7yKt5yYOY8IsFpYMS
   141GauIXM0Of7hTyjpBCX1Ml4ApbvyyRzngOliUN779cQW3WphYGq05aE+0RQyxNXJ
   15EghuCkBD
   16=egea
   17-----END PGP SIGNATURE-----
   

8. maflcko merged this on Oct 31, 2022
9. maflcko closed this on Oct 31, 2022

   ---

10. fanquake deleted the branch on Oct 31, 2022
11. delta1 referenced this in commit 477a871a16 on Sep 24, 2023
12. bitcoin locked this on Oct 31, 2023

Contributors
fanquake maflcko

Labels
Backport

Milestone
23.1