[22.1] Backports #26413

1. 
   fanquake commented at 10:54 am on October 28, 2022: member

   Currently backports:

   • #26275
   • #26321

   Will leave open to collect backports for 22.1,

2. Adjust `.tx/config` for new Transifex CLI

   The old Transifex Command-Line Tool is considered deprecated (as of
   January 2022) and will sunset on Nov 30, 2022.
   
   See: https://github.com/transifex/cli/blob/devel/README.md#migrating-from-older-versions-of-the-client
   
   An accompanying PR: https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/142
   
   Github-Pull: #26321
   Rebased-From: d6adbb7ee1de661ad89879609eecd11129322405

   d174db0f3d
3. rpc: fix crash in deriveaddresses when derivation index is 2147483647

   2147483647 is the maximum positive value of a signed int32, and - currently -
   the maximum value that the deriveaddresses bitcoin RPC call accepts as
   derivation index due to its input validation routines.
   
   Before this change, when the derivation index (and thus range_end) reached
   std::numeric_limits<int_32_t>::max(), the "i" variable in the for cycle (which
   is declared as int, and as such 32 bits in size on most platforms) would be
   incremented at the end of the first iteration and then warp back to
   -2147483648. This caused SIGABRT in bitcoind and a core dump.
   
   This change assigns "i" an explicit size of 64 bits on every platform,
   sidestepping the problem.
   
   Fixes #26274.
   
   Github-Pull: #26275
   Rebased-From: addf9d6502db12cebcc5976df3111cac1a369b82

   db20d278e2
4. rpc: add non-regression test about deriveaddresses crash when index is 2147483647

   This test would cause a crash in bitcoind (see #26274) if the fix given in the
   previous commit was not applied.
   
   Github-Pull: #26275
   Rebased-From: 9153ff3e274953ea0d92d53ddab4c72deeace1b1

   403de22119
5. fanquake added the label Backport on Oct 28, 2022
6. fanquake added this to the milestone 22.1 on Oct 28, 2022
7. 
   maflcko commented at 3:45 pm on October 31, 2022: member

   cherry-pick ACK 403de22119f5c65a9fd43a665c469512b967ed38 🏔

   Signature:

    0-----BEGIN PGP SIGNED MESSAGE-----
    1Hash: SHA512
    2
    3cherry-pick ACK 403de22119f5c65a9fd43a665c469512b967ed38  🏔
    4-----BEGIN PGP SIGNATURE-----
    5
    6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    7pUgfnQv9EuZ6SZxUGyBlU/Hm6w0omN/XcMSJoFyyBrEVGO+W3j63W6T41p3G3Y6U
    8EmSKdxGIQelclEeyc2dqSA7C8WCTjBIy+nYwlbMLI2ovMXeqMrmO6sc78r/qaBlq
    9z6LB0XIuCTjx8MlFz6dw9P9Fzq4S8pZosLua66WmfWpSU8Kidwjnxe1qNVQNVE+r
   10TDMY0dIXU4KNGntme/B3ushwV+wX3Shs3l9n9JoE9vCsQMob5HjadsBc0OelmgaF
   11fdJRNa/MPOSXnVr27tbYUVYiZl/p6ZMeehuqjkWx0g2H+xozVWAeo07WicqEjceA
   12SN6mvNnxInZBtVuC3gi8TxkpzZoLw4xz5jxSxazrWy/l+TIMJEoVhhnbcE6Sh1fX
   13GW3WR0RloG01+4xYHZFEpDcFV68c/1DJOcyvdrTqyctswA96o560606QbW2ygoRC
   14zOWHdUiQksDufiPkvc1wQV20DAlQzIVtNr9FSxGDnSjnuWsfcKNpfWKU2S+sm2VP
   15+RNz/d2y
   16=IzZq
   17-----END PGP SIGNATURE-----
   

8. maflcko merged this on Oct 31, 2022
9. maflcko closed this on Oct 31, 2022

   ---

10. fanquake deleted the branch on Oct 31, 2022
11. bitcoin locked this on Oct 31, 2023

Contributors
fanquake maflcko

Labels
Backport

Milestone
22.1