build: copy config.{guess,sub} post autogen in zmq package

fanquake commented at 2:54 pm on October 29, 2022: member

Otherwise our config.guess and config.sub will be copied over. This problem has been masked by the fact that modern systems ship with versions that recognise all the triplets we use (namely arm64-apple-darwin). However building on ubuntu 20.04 surfaces the issue.

Fixes #26420.

Otherwise our config.guess and config.sub will be copied over. This
problem has been masked by the fact that modern systems ship with
versions that recognise all the triplets we use (namely
arm64-apple-darwin). However building on ubuntu 20.04 surfaces the
issue.

Fixes #26420.

1914e470e3

fanquake added the label Build system on Oct 29, 2022

maflcko added the label DrahtBot Guix build requested on Oct 29, 2022

hebasto approved

hebasto commented at 11:36 am on October 30, 2022: member

ACK 1914e470e327091c625f627b4447beb336f7fe5a, tested on Ubuntu 18.04.

Updating of config.{guess,sub} files was introduced in 0d1f38c45ff40f17b42074e3b58211e794a19edb. And it worked well until got broken in 6897c4bdf51a4aa74320ebfffa9467db14670109, where the added ./autogen.sh invocation overwrites them back.

Does it worth moving such copying commands from $(package)_preprocess_cmds into $(package)_config_cmds for all packages, for the sake of consistency?

DrahtBot commented at 6:39 am on October 31, 2022: contributor

Guix builds

File	commit 4f270d2b63913b86c4366756031c5003837075d6(master)	commit be5c0a518fbdc469c7fa745c72a34bda6290e919(master and this pull)
SHA256SUMS.part	`7d3f845a90fb6abc...`	`da0b62239fd55dc6...`
*-aarch64-linux-gnu-debug.tar.gz	`9c769a061bceb8e3...`	`cf39ed45d0b5dffa...`
*-aarch64-linux-gnu.tar.gz	`f9bdb0ccfb55a174...`	`dfb054a676dc2581...`
*-arm-linux-gnueabihf-debug.tar.gz	`15016d74cbd49bdc...`	`8163f726ff50a6df...`
*-arm-linux-gnueabihf.tar.gz	`002988568719034e...`	`cf47465e6e8578bc...`
*-arm64-apple-darwin-unsigned.dmg	`a0b5a2ccf3101bf3...`
*-arm64-apple-darwin-unsigned.tar.gz	`435e0ef0630f80c5...`
*-arm64-apple-darwin.tar.gz	`0d2e4ab923fa3add...`
*-powerpc64-linux-gnu-debug.tar.gz	`93c64ca977cd8886...`
*-powerpc64-linux-gnu.tar.gz	`b992f7c52590a796...`
*-powerpc64le-linux-gnu-debug.tar.gz	`a3f3d470b6ebee54...`
*-powerpc64le-linux-gnu.tar.gz	`1b3c5bb636425886...`
*-riscv64-linux-gnu-debug.tar.gz	`345308a966364a40...`	`1cf6616a3054c3c6...`
*-riscv64-linux-gnu.tar.gz	`df5fc6b5567f9e28...`	`3532a5f5d8499a74...`
*-win64-debug.zip	`d6b342dc04ff9b9c...`
*-win64-setup-unsigned.exe	`b1c4068761ad56b4...`
*-win64-unsigned.tar.gz	`9d1fa9626597af4b...`
*-win64.zip	`d5b0c4bf1eed82f9...`
*-x86_64-apple-darwin-unsigned.dmg	`2507b7c3d14c7e15...`
*-x86_64-apple-darwin-unsigned.tar.gz	`dfbe72b08ef16b60...`
*-x86_64-apple-darwin.tar.gz	`1389fe7776b89c6f...`
*-x86_64-linux-gnu-debug.tar.gz	`ccd7f2a574759044...`	`c65a6e989eb0ba87...`
*-x86_64-linux-gnu.tar.gz	`b52cc5bcc8c29fae...`	`4a6fcd8990e0e2a4...`
*.tar.gz	`794151b221e91980...`	`ac97c8141bba0b6a...`
guix_build.log	`60f2e77d129a4e3b...`	`b5abee3306dbfa69...`
guix_build.log.diff		`80f2807fedef3a3c...`

DrahtBot removed the label DrahtBot Guix build requested on Oct 31, 2022

maflcko added the label DrahtBot Guix build requested on Oct 31, 2022

luke-jr commented at 6:01 pm on November 5, 2022: member

Hmm, won’t this break native builds that require a newer config.* than we ship?

DrahtBot commented at 6:32 pm on November 6, 2022: contributor

Guix builds

File	commit bf0cb4399061c6827bd5d7428a146010102d7ab1(master)	commit 91d0d07161c6c15975564cdfaa03541bb46546e9(master and this pull)
SHA256SUMS.part	`7ded06160eb09372...`	`71d6432a7ec9fdaf...`
*-aarch64-linux-gnu-debug.tar.gz	`76ee7076c7f100df...`	`d9dbcc6cf9fbc81b...`
*-aarch64-linux-gnu.tar.gz	`3da1cc1aecf16ad4...`	`e99d8a45ca40e27d...`
*-arm-linux-gnueabihf-debug.tar.gz	`2822711b2e465ba2...`	`33f7c85c05c2e92f...`
*-arm-linux-gnueabihf.tar.gz	`ef3fb721e21396b3...`	`f820911defc6c89f...`
*-arm64-apple-darwin-unsigned.dmg	`041b5b42534c688e...`	`3b2661cdfa70ac22...`
*-arm64-apple-darwin-unsigned.tar.gz	`d89d58472e837b67...`	`789576f618be4cba...`
*-arm64-apple-darwin.tar.gz	`e5b758012e63a970...`	`c9353682805cc81a...`
*-powerpc64-linux-gnu-debug.tar.gz	`e88a184fbe61e9be...`	`06e068e46ff1aad5...`
*-powerpc64-linux-gnu.tar.gz	`e18597366db41a84...`	`af5fab4a85969d79...`
*-powerpc64le-linux-gnu-debug.tar.gz	`97349093b86b4012...`	`db79d0fe7a7c7e3b...`
*-powerpc64le-linux-gnu.tar.gz	`975fd98f35974703...`	`d5f849d75fc175ed...`
*-riscv64-linux-gnu-debug.tar.gz	`d70e3a3843ff8c17...`	`02c8ed08b087e51a...`
*-riscv64-linux-gnu.tar.gz	`435e4b4e628cc595...`	`d2c1e548602c8dcd...`
*-win64-debug.zip	`b667d15784957025...`	`03f9b5ee40f79e60...`
*-win64-setup-unsigned.exe	`134b7722430b2e20...`	`3777197bbac2ec57...`
*-win64-unsigned.tar.gz	`55e1e8ce589fbe96...`	`5e4c5268fbe1a289...`
*-win64.zip	`20e66255e29f5d27...`	`8ade964a6eba6331...`
*-x86_64-apple-darwin-unsigned.dmg	`c57925d0c124b462...`	`d85ec1c740611225...`
*-x86_64-apple-darwin-unsigned.tar.gz	`b9d677493dae5603...`	`c86d5e950d777b84...`
*-x86_64-apple-darwin.tar.gz	`31e56bd9195bbf79...`	`31ae52259626c2db...`
*-x86_64-linux-gnu-debug.tar.gz	`9557cc77241d8977...`	`2ca611d62be7bf91...`
*-x86_64-linux-gnu.tar.gz	`5bae5eff14303285...`	`2134390a02a57e7a...`
*.tar.gz	`0b069c3f209327aa...`	`a2e8c3cab9a4b7e5...`
guix_build.log	`1e35ab8b6a618fdc...`	`b890a367c833d894...`
guix_build.log.diff		`af665c8a371542d6...`

DrahtBot removed the label DrahtBot Guix build requested on Nov 6, 2022

jarolrod commented at 1:21 am on November 20, 2022: member

GUIX hashes

x86:

 041352df92562dd370de33654f49346cdb35a91b9424f25349e6f714dc9792660  guix-build-1914e470e327/output/aarch64-linux-gnu/SHA256SUMS.part
 12fe4165257f860535bfb12e555186fd6a18bcdd2bc6be3a091c3063209ecabc3  guix-build-1914e470e327/output/aarch64-linux-gnu/bitcoin-1914e470e327-aarch64-linux-gnu-debug.tar.gz
 248d0cd4959867957bfd282dec13318aaf94f473face4a6f24fa30f8cca2122f0  guix-build-1914e470e327/output/aarch64-linux-gnu/bitcoin-1914e470e327-aarch64-linux-gnu.tar.gz
 3fc6aaf2cd48649d9c7a1ca57d526896ca659526435eaffc5685d0866c720026b  guix-build-1914e470e327/output/arm-linux-gnueabihf/SHA256SUMS.part
 4df32c6271868f81cbec6a1674a9bb79ae1af49fc92f9a907cdfdfc933124e86f  guix-build-1914e470e327/output/arm-linux-gnueabihf/bitcoin-1914e470e327-arm-linux-gnueabihf-debug.tar.gz
 565c9e81594d99fcf94a8d5f16f4a9df1fc65c5b3272428f0c68938910cd9619f  guix-build-1914e470e327/output/arm-linux-gnueabihf/bitcoin-1914e470e327-arm-linux-gnueabihf.tar.gz
 64957ede7a87d4ceee280a4901e536385cf8c2bdbc749b71a89b7a076387a3bd5  guix-build-1914e470e327/output/arm64-apple-darwin/SHA256SUMS.part
 72352a2338ddb0d393c293a5d01ffe0f75a55175d4bc7eb1e019d98d34cd75f08  guix-build-1914e470e327/output/arm64-apple-darwin/bitcoin-1914e470e327-arm64-apple-darwin-unsigned.dmg
 889de10e78f994bf2df68c1d73a3994fa8b1c8024a2186a3a9d20682d89953fed  guix-build-1914e470e327/output/arm64-apple-darwin/bitcoin-1914e470e327-arm64-apple-darwin-unsigned.tar.gz
 9a8b5d5357ff4555fa76d3c6f142d67db2c9905ccfb18ba7947cdf8a7512fd120  guix-build-1914e470e327/output/arm64-apple-darwin/bitcoin-1914e470e327-arm64-apple-darwin.tar.gz
103c049d932d2f871ff2bf4b64d39f2dca3b1135b1d6093fc62cde6491a99df6ae  guix-build-1914e470e327/output/dist-archive/bitcoin-1914e470e327.tar.gz
114f24f344d1f81894862fdad974a23c9e2acc0963c50553477576cacba1d741e3  guix-build-1914e470e327/output/powerpc64-linux-gnu/SHA256SUMS.part
124cf09e2654838555ef9a03c305a05d6e56379c2eef870194c7c2f102c1338b17  guix-build-1914e470e327/output/powerpc64-linux-gnu/bitcoin-1914e470e327-powerpc64-linux-gnu-debug.tar.gz
137d071261145e28ed65bc33d70b5eb6d2f7fd6abc2580af573e8ecde90b2b3e3f  guix-build-1914e470e327/output/powerpc64-linux-gnu/bitcoin-1914e470e327-powerpc64-linux-gnu.tar.gz
14fc3e9409c7376c03bfaf715430b261d4eb384d8d85c0d3030edd571d3f5e6788  guix-build-1914e470e327/output/powerpc64le-linux-gnu/SHA256SUMS.part
15c602d2e1c7485c1f27e2f0a2558894448ee7ef0c7614b4722ff338b1e3decf24  guix-build-1914e470e327/output/powerpc64le-linux-gnu/bitcoin-1914e470e327-powerpc64le-linux-gnu-debug.tar.gz
16c067c610ff59aa00877dcb022f179abce9cfb5b73754d99478cdd6d4707d3c9f  guix-build-1914e470e327/output/powerpc64le-linux-gnu/bitcoin-1914e470e327-powerpc64le-linux-gnu.tar.gz
174001f42c77f3798d2411fea041e6e59d1f90bce22585872104f7acbe73c1f50f  guix-build-1914e470e327/output/riscv64-linux-gnu/SHA256SUMS.part
18cf5eb0bfba47732935fa3ec2c6792302f6475e466dcc60a26c2b5eb2de273ab9  guix-build-1914e470e327/output/riscv64-linux-gnu/bitcoin-1914e470e327-riscv64-linux-gnu-debug.tar.gz
1977fd268895a7dd7107fbd82a2c447ca3b34a2f67656c0571a46867f87d78153b  guix-build-1914e470e327/output/riscv64-linux-gnu/bitcoin-1914e470e327-riscv64-linux-gnu.tar.gz
202e7364888b6c206e431b637e1c6180b150c479fda7d4f5e28f0a71671cfbb488  guix-build-1914e470e327/output/x86_64-apple-darwin/SHA256SUMS.part
21a3c37922903b42239b2d981a097a5a4b18e9f45589f0560ed0ed421af402f6e3  guix-build-1914e470e327/output/x86_64-apple-darwin/bitcoin-1914e470e327-x86_64-apple-darwin-unsigned.dmg
22b5b4fccbf14ecad4899bbe060fc2b37c55046274faaf1f4e4e4c109766414247  guix-build-1914e470e327/output/x86_64-apple-darwin/bitcoin-1914e470e327-x86_64-apple-darwin-unsigned.tar.gz
23fb9f64dd350f12e85c62bfc4f8b7cecad548b8e8d7a3170ac97b19f384af367d  guix-build-1914e470e327/output/x86_64-apple-darwin/bitcoin-1914e470e327-x86_64-apple-darwin.tar.gz
24fd5e30d8ef5d284ced85e925d1b067b264468f7e1616304db90a1241825a0af0  guix-build-1914e470e327/output/x86_64-linux-gnu/SHA256SUMS.part
25804f69ea2efb8a67c54a06e2d37f7321a59e9bb1139b6ab4d21b9ecb6575dc5d  guix-build-1914e470e327/output/x86_64-linux-gnu/bitcoin-1914e470e327-x86_64-linux-gnu-debug.tar.gz
26bc4d0b50b78e5ea9d22509154c263b126ffa3a7710d1cd94fd487710d20688d2  guix-build-1914e470e327/output/x86_64-linux-gnu/bitcoin-1914e470e327-x86_64-linux-gnu.tar.gz
2724fb55c39526b258829eb72c4cc0935b2531611efd0a2adbdcc3844420bda331  guix-build-1914e470e327/output/x86_64-w64-mingw32/SHA256SUMS.part
282d13edca9c9e26af4154a1c7662bd93db25921b271a80cc200aca18835a14d8a  guix-build-1914e470e327/output/x86_64-w64-mingw32/bitcoin-1914e470e327-win64-debug.zip
2982af928c2402d79941a6b6e983e9046e4a50cf733c448fc77297d1df057c11c0  guix-build-1914e470e327/output/x86_64-w64-mingw32/bitcoin-1914e470e327-win64-setup-unsigned.exe
30eae30e98a1a357a763070fd39566db6ab6943fe1693fc92911f28c7e01195e6d  guix-build-1914e470e327/output/x86_64-w64-mingw32/bitcoin-1914e470e327-win64-unsigned.tar.gz
3123387933302e03ee5db762854c671b91b9948f1438af18701f176d2575d75ee3  guix-build-1914e470e327/output/x86_64-w64-mingw32/bitcoin-1914e470e327-win64.zip

arm64:

 041352df92562dd370de33654f49346cdb35a91b9424f25349e6f714dc9792660  guix-build-1914e470e327/output/aarch64-linux-gnu/SHA256SUMS.part
 12fe4165257f860535bfb12e555186fd6a18bcdd2bc6be3a091c3063209ecabc3  guix-build-1914e470e327/output/aarch64-linux-gnu/bitcoin-1914e470e327-aarch64-linux-gnu-debug.tar.gz
 248d0cd4959867957bfd282dec13318aaf94f473face4a6f24fa30f8cca2122f0  guix-build-1914e470e327/output/aarch64-linux-gnu/bitcoin-1914e470e327-aarch64-linux-gnu.tar.gz
 3fc6aaf2cd48649d9c7a1ca57d526896ca659526435eaffc5685d0866c720026b  guix-build-1914e470e327/output/arm-linux-gnueabihf/SHA256SUMS.part
 4df32c6271868f81cbec6a1674a9bb79ae1af49fc92f9a907cdfdfc933124e86f  guix-build-1914e470e327/output/arm-linux-gnueabihf/bitcoin-1914e470e327-arm-linux-gnueabihf-debug.tar.gz
 565c9e81594d99fcf94a8d5f16f4a9df1fc65c5b3272428f0c68938910cd9619f  guix-build-1914e470e327/output/arm-linux-gnueabihf/bitcoin-1914e470e327-arm-linux-gnueabihf.tar.gz
 64957ede7a87d4ceee280a4901e536385cf8c2bdbc749b71a89b7a076387a3bd5  guix-build-1914e470e327/output/arm64-apple-darwin/SHA256SUMS.part
 72352a2338ddb0d393c293a5d01ffe0f75a55175d4bc7eb1e019d98d34cd75f08  guix-build-1914e470e327/output/arm64-apple-darwin/bitcoin-1914e470e327-arm64-apple-darwin-unsigned.dmg
 889de10e78f994bf2df68c1d73a3994fa8b1c8024a2186a3a9d20682d89953fed  guix-build-1914e470e327/output/arm64-apple-darwin/bitcoin-1914e470e327-arm64-apple-darwin-unsigned.tar.gz
 9a8b5d5357ff4555fa76d3c6f142d67db2c9905ccfb18ba7947cdf8a7512fd120  guix-build-1914e470e327/output/arm64-apple-darwin/bitcoin-1914e470e327-arm64-apple-darwin.tar.gz
103c049d932d2f871ff2bf4b64d39f2dca3b1135b1d6093fc62cde6491a99df6ae  guix-build-1914e470e327/output/dist-archive/bitcoin-1914e470e327.tar.gz
114f24f344d1f81894862fdad974a23c9e2acc0963c50553477576cacba1d741e3  guix-build-1914e470e327/output/powerpc64-linux-gnu/SHA256SUMS.part
124cf09e2654838555ef9a03c305a05d6e56379c2eef870194c7c2f102c1338b17  guix-build-1914e470e327/output/powerpc64-linux-gnu/bitcoin-1914e470e327-powerpc64-linux-gnu-debug.tar.gz
137d071261145e28ed65bc33d70b5eb6d2f7fd6abc2580af573e8ecde90b2b3e3f  guix-build-1914e470e327/output/powerpc64-linux-gnu/bitcoin-1914e470e327-powerpc64-linux-gnu.tar.gz
14fc3e9409c7376c03bfaf715430b261d4eb384d8d85c0d3030edd571d3f5e6788  guix-build-1914e470e327/output/powerpc64le-linux-gnu/SHA256SUMS.part
15c602d2e1c7485c1f27e2f0a2558894448ee7ef0c7614b4722ff338b1e3decf24  guix-build-1914e470e327/output/powerpc64le-linux-gnu/bitcoin-1914e470e327-powerpc64le-linux-gnu-debug.tar.gz
16c067c610ff59aa00877dcb022f179abce9cfb5b73754d99478cdd6d4707d3c9f  guix-build-1914e470e327/output/powerpc64le-linux-gnu/bitcoin-1914e470e327-powerpc64le-linux-gnu.tar.gz
174001f42c77f3798d2411fea041e6e59d1f90bce22585872104f7acbe73c1f50f  guix-build-1914e470e327/output/riscv64-linux-gnu/SHA256SUMS.part
18cf5eb0bfba47732935fa3ec2c6792302f6475e466dcc60a26c2b5eb2de273ab9  guix-build-1914e470e327/output/riscv64-linux-gnu/bitcoin-1914e470e327-riscv64-linux-gnu-debug.tar.gz
1977fd268895a7dd7107fbd82a2c447ca3b34a2f67656c0571a46867f87d78153b  guix-build-1914e470e327/output/riscv64-linux-gnu/bitcoin-1914e470e327-riscv64-linux-gnu.tar.gz
202e7364888b6c206e431b637e1c6180b150c479fda7d4f5e28f0a71671cfbb488  guix-build-1914e470e327/output/x86_64-apple-darwin/SHA256SUMS.part
21a3c37922903b42239b2d981a097a5a4b18e9f45589f0560ed0ed421af402f6e3  guix-build-1914e470e327/output/x86_64-apple-darwin/bitcoin-1914e470e327-x86_64-apple-darwin-unsigned.dmg
22b5b4fccbf14ecad4899bbe060fc2b37c55046274faaf1f4e4e4c109766414247  guix-build-1914e470e327/output/x86_64-apple-darwin/bitcoin-1914e470e327-x86_64-apple-darwin-unsigned.tar.gz
23fb9f64dd350f12e85c62bfc4f8b7cecad548b8e8d7a3170ac97b19f384af367d  guix-build-1914e470e327/output/x86_64-apple-darwin/bitcoin-1914e470e327-x86_64-apple-darwin.tar.gz
24fd5e30d8ef5d284ced85e925d1b067b264468f7e1616304db90a1241825a0af0  guix-build-1914e470e327/output/x86_64-linux-gnu/SHA256SUMS.part
25804f69ea2efb8a67c54a06e2d37f7321a59e9bb1139b6ab4d21b9ecb6575dc5d  guix-build-1914e470e327/output/x86_64-linux-gnu/bitcoin-1914e470e327-x86_64-linux-gnu-debug.tar.gz
26bc4d0b50b78e5ea9d22509154c263b126ffa3a7710d1cd94fd487710d20688d2  guix-build-1914e470e327/output/x86_64-linux-gnu/bitcoin-1914e470e327-x86_64-linux-gnu.tar.gz
2724fb55c39526b258829eb72c4cc0935b2531611efd0a2adbdcc3844420bda331  guix-build-1914e470e327/output/x86_64-w64-mingw32/SHA256SUMS.part
282d13edca9c9e26af4154a1c7662bd93db25921b271a80cc200aca18835a14d8a  guix-build-1914e470e327/output/x86_64-w64-mingw32/bitcoin-1914e470e327-win64-debug.zip
2982af928c2402d79941a6b6e983e9046e4a50cf733c448fc77297d1df057c11c0  guix-build-1914e470e327/output/x86_64-w64-mingw32/bitcoin-1914e470e327-win64-setup-unsigned.exe
30eae30e98a1a357a763070fd39566db6ab6943fe1693fc92911f28c7e01195e6d  guix-build-1914e470e327/output/x86_64-w64-mingw32/bitcoin-1914e470e327-win64-unsigned.tar.gz
3123387933302e03ee5db762854c671b91b9948f1438af18701f176d2575d75ee3  guix-build-1914e470e327/output/x86_64-w64-mingw32/bitcoin-1914e470e327-win64.zip

DrahtBot commented at 1:21 am on November 20, 2022: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

fanquake commented at 4:42 pm on February 6, 2023: member

Hmm, won’t this break native builds that require a newer config.* than we ship?

Possibly, however I don’t think we’ve ever run into an instance of that happening. More often than not, the issue is the opposite, and the system config.guess/sub are not new enough. Hence why we use this copying-over method in multiple other depends packages; it’s been a necessity for RISC-V and arm64-darwin.

fanquake merged this on Feb 7, 2023

fanquake closed this on Feb 7, 2023

sidhujag referenced this in commit 7ea4a1a9dd on Feb 7, 2023

fanquake deleted the branch on Sep 11, 2023

bitcoin locked this on Sep 10, 2024

build: copy config.{guess,sub} post autogen in zmq package #26421

Guix builds

Guix builds

Reviews