allow txindex to be removed and add a reindex dialog #2648

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:txindex changing 2 files +8 −5

Diapolo commented at 6:29 AM on May 13, 2013: none
- adds a reindex dialog for Bitcoin-Qt to change -txindex without the need to supply -reindex
- now also does a -reindex, when removing the -txindex switch
BitcoinPullTester commented at 6:57 AM on May 13, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e3046c752fbdf04445b50f4fb7d13be4e9a92bc3 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 4:59 PM on May 13, 2013: member

What dialog? I don't see any GUI changes :)

Can you explain when this is useful?
Diapolo commented at 5:17 PM on May 13, 2013: none

This is now shown, when you first-time add -txindex or when you first remove that comman-line option.

Clicking OK will directly start the reindex, without the need to supply -reindex.
Diapolo commented at 6:21 AM on May 17, 2013: none

@sipa What do you think?
sipa commented at 6:05 PM on May 21, 2013: member

What happens with bitcoind with this?
Diapolo commented at 1:26 PM on May 22, 2013: none

@sipa Nothing (exit)? It prints to the console just like when a DB corruption is detected, which already is a dialog for Bitcoin-Qt and just a message for bitcoind.
sipa commented at 3:16 AM on May 30, 2013: member

ACK. @Diapolo Right, that should be changed (we've had console users type 'ye' in the terminal after bitcoind exits with "Do you want to reindex now?"), but that's outside of the scope of this PR.
jgarzik commented at 4:16 PM on May 30, 2013: contributor

ACK
laanwj commented at 3:11 PM on May 31, 2013: member

ACK
Diapolo commented at 11:04 AM on June 1, 2013: none

Rebased, fixes merge-conflict.
BitcoinPullTester commented at 11:09 AM on June 2, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/3a10b04bdbb08059e0a49f440cb0d82871806f7f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

allow txindex to be removed and add a reindex dialog

- adds a reindex dialog for Bitcoin-Qt to change -txindex without the need
  to supply -reindex
- now also does a -reindex, when removing the -txindex switch

0206e38dcd

BitcoinPullTester commented at 5:07 AM on June 13, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0206e38dcd32e0cc76c6f0e08197a2a72bef0fb1 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 10:46 AM on June 14, 2013: none

Any reason to not merge this?
sipa referenced this in commit e58154c447 on Jun 15, 2013
sipa merged this on Jun 15, 2013
sipa closed this on Jun 15, 2013
wtogami commented at 11:20 AM on August 15, 2013: contributor

Please note that this patch added an unintended error message in Issue #2893.
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#2782 Initializing a new database with -txindex=1 set asks for reindex #2893 Unintended error message added by txindex remove patch