test: Add getpeerinfo test for missing version message #26519

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2211-test-rpc-no-ver-📂 changing 1 files +48 −0
  1. maflcko commented at 10:22 am on November 17, 2022: member

    There seems to be a lot of discussion about behaviour/code that is completely untested.

    Fix this by adding a test. The test documents the current behaviour and helps to detect when the behaviour changes in the future.

  2. test: Add getpeerinfo test for missing version message fa68d086f3
  3. fanquake added the label Tests on Nov 17, 2022
  4. maflcko added this to the milestone 24.1 on Nov 17, 2022
  5. maflcko removed this from the milestone 24.1 on Nov 17, 2022
  6. fanquake requested review from dergoegge on Nov 17, 2022
  7. fanquake requested review from mzumsande on Nov 17, 2022
  8. jonatack commented at 6:11 pm on November 17, 2022: contributor
    ACK fa68d086f33cb4fc13877308d21b6344a804a222
  9. DrahtBot commented at 6:11 pm on November 17, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Count Reviewers
    ACK 2 jonatack, mzumsande
  10. mzumsande commented at 10:12 pm on November 17, 2022: contributor
    Code Review ACK fa68d086f33cb4fc13877308d21b6344a804a222
  11. maflcko removed the label Tests on Nov 18, 2022
  12. DrahtBot added the label Tests on Nov 18, 2022
  13. maflcko merged this on Nov 18, 2022
  14. maflcko closed this on Nov 18, 2022

  15. maflcko deleted the branch on Nov 18, 2022
  16. sidhujag referenced this in commit a9f31caee9 on Nov 18, 2022
  17. bitcoin locked this on Nov 18, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me