[23.x] GUI backports #26522

pull hebasto wants to merge 1 commits into bitcoin:23.x from hebasto:221117-23.1-gui-bp changing 1 files +2 −2
  1. hebasto commented at 2:42 PM on November 17, 2022: member

    Backports:

    • bitcoin-core/gui#680
  2. Fixes bitcoin#26490 by preventing notifications
    MacOS 13 sends a window focus change notification after the main
    window has been destroyed but before the QTApplication has been
    destroyed. This results in the menu bar receiving a notification
    despite it no longer existing. The solution is to pass the main
    window as context when subscribing to the notifications. Qt
    automatically unsubscribes to notifications if the sender OR
    context is destroyed.
    
    Github-Pull: bitcoin-core/gui#680
    Rebased-From: 8a5014cd8a05b3ab86ae34a47653a82ce11bdf17
    e54a4deff8
  3. hebasto added the label Backport on Nov 17, 2022
  4. hebasto added this to the milestone 23.1 on Nov 17, 2022
  5. fanquake requested review from jarolrod on Nov 18, 2022
  6. jarolrod approved
  7. jarolrod commented at 8:53 PM on November 18, 2022: member

    ACK e54a4deff85d079099c76fb63c128fa597834f75

    Confirmed the issue by running 23.x on macOS Ventura, this backport fixes the issue.

  8. DrahtBot commented at 8:53 PM on November 18, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK jarolrod
  9. fanquake merged this on Nov 21, 2022
  10. fanquake closed this on Nov 21, 2022

  11. hebasto deleted the branch on Nov 21, 2022
  12. fanquake referenced this in commit ea9aa3f02f on Nov 22, 2022
  13. jamesdorfman referenced this in commit 69bcb5f6bf on Sep 25, 2023
  14. bitcoin locked this on Nov 21, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me