This class was introduced in commit fa3365430c5fb57d7c0b5f2bce9fbbe290be93c3 ("net: Use mockable time for ping/pong, add tests"), but actually never used.
test: remove unused class `NodePongAdd1` #26546
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202211-test-remove_unused_nodepongadd1_class changing 1 files +2 −8-
theStack commented at 11:54 AM on November 21, 2022: contributor
-
DrahtBot commented at 11:54 AM on November 21, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK stickies-v - DrahtBot added the label Tests on Nov 21, 2022
-
maflcko commented at 12:00 PM on November 21, 2022: member
The commit was fa3365430c5fb57d7c0b5f2bce9fbbe290be93c3
-
40bdc8a6e4
test: remove unused class `NodePongAdd1`
This class was introduced in commit fa3365430c5fb57d7c0b5f2bce9fbbe290be93c3 ("net: Use mockable time for ping/pong, add tests"), but actually never used. - theStack force-pushed on Nov 21, 2022
-
- stickies-v approved
-
stickies-v commented at 3:10 PM on November 21, 2022: contributor
ACK 40bdc8a6e
Usage of
NodePongAdd1was removed by force push in the same PR it was introduced in, so this seems like an accidental leftover. - fanquake merged this on Nov 21, 2022
- fanquake closed this on Nov 21, 2022
- theStack deleted the branch on Nov 21, 2022
- sidhujag referenced this in commit 322a588c4d on Nov 21, 2022
- bitcoin locked this on Nov 21, 2023
Contributors
Labels