Update bitcoin-qt.pro Brew patch to set OpenSSL lib paths #2655

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:brew-qt-pro-openssl changing 1 files +8 −2

fanquake commented at 3:51 AM on May 15, 2013: member

It's possible that OpenSSL might not be not linked correctly after installation via Brew, and if this hasn't been remedied with "brew force" then you could unknowingly be building with OSX's outdated OpenSSL.
Update bitcoin-qt.pro brew patch to set OpenSSL lib paths c63791170b
BitcoinPullTester commented at 4:25 AM on May 15, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c63791170b55a5bcffc7e631fb42ef462706eb3a for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

in contrib/homebrew/bitcoin.qt.pro.patch:None in c63791170b

  28 | @@ -29,4 +29,10 @@ index d938c07..e1dd4ec 100644
  29 |  +    macx:BOOST_INCLUDE_PATH = /usr/local/opt/boost/include
  30 |   }
  31 |   
  32 | ++macx:OPENSSL_LIB_PATH = /usr/local/opt/openssl
  33 | ++
  34 | ++macx:OPENSSL_LIB_PATH = /usr/local/opt/openssl/include
  35 | ++
  36 |   win32:DEFINES += WIN32
  37 | + win32:RC_FILE = src/qt/res/bitcoin-qt.rc

Diapolo commented at 11:35 AM on May 26, 2013:

What is this doing here? Thought this is Mac OpenSSL related :).

fanquake commented at 12:00 PM on May 26, 2013:

@Diapolo bitcoin-qt.pro has changed since I originally created the patch. So as well as adding the openssl lib defines, it brings the patch up to date.

fanquake commented at 12:42 PM on June 23, 2013: member

Decided that this is essentially two separate issues that should be in separate pulls. Going to close this and open separate ones in the future.
fanquake closed this on Jun 23, 2013
fanquake deleted the branch on Jun 23, 2013
DrahtBot locked this on Sep 8, 2021

Contributors

fanquake

BitcoinPullTester

Diapolo