This PR makes the CNode message processing queue private and provides an interface for polling it through CConnman. This would be useful in the context of #25515 to mock the message processing queue but also serves as a little improvement on the networking module interface.
net: Make CNode message process queue private #26583
pull dergoegge wants to merge 1 commits into bitcoin:master from dergoegge:2022-11-connman-pollmessage changing 3 files +31 −15-
dergoegge commented at 5:04 PM on November 26, 2022: member
-
[net] Add CConnman::PollMessage 6a7a821a80
-
DrahtBot commented at 5:04 PM on November 26, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #25515 (net, test: Virtualise CConnman and add initial PeerManager unit tests by dergoegge)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- dergoegge renamed this:
[net] Make CNode message process queue private
net: Make CNode message process queue private
on Nov 26, 2022 - DrahtBot added the label P2P on Nov 26, 2022
-
luke-jr commented at 11:32 PM on November 28, 2022: member
(Sounds like an unnecessary refactor with no end goal.)
-
dergoegge commented at 11:55 AM on December 7, 2022: member
I'll probably include this at some point in a larger refactor that demonstrates the benefit directly.
- dergoegge closed this on Dec 7, 2022
- bitcoin locked this on Dec 7, 2023
Labels