Currently devs are free to set or not set the wallet type in the test_runner when only one type is allowed to be set.
This is inconsistent and causes review comments such as:
test: Set wallet type in test_runner when only one type is allowed #26600
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2211-test-wallet-type-💤 changing 2 files +10 −6-
maflcko commented at 1:34 PM on November 29, 2022: member
-
test: Set wallet type in test_runner when only one type is allowed fadb8696dd
-
DrahtBot commented at 1:34 PM on November 29, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #26152 (Bump unconfirmed ancestor transactions to target feerate by Xekyo)
- #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Tests on Nov 29, 2022
-
achow101 commented at 11:08 PM on November 29, 2022: member
ACK fadb8696dd0f7569e429fb6568a66866d67a2ce6
- maflcko merged this on Nov 30, 2022
- maflcko closed this on Nov 30, 2022
- maflcko deleted the branch on Nov 30, 2022
- hebasto added this to the milestone 24.0.1 on Nov 30, 2022
- hebasto removed this from the milestone 24.0.1 on Nov 30, 2022
- sidhujag referenced this in commit c35470bbb5 on Dec 1, 2022
- bitcoin locked this on Nov 30, 2023
Labels