test: Move wallet tests to wallet_*.py #26601

1. 
   maflcko commented at 2:09 pm on November 29, 2022: member

   The tests only tests the wallet and it doesn’t make sense to extend it for other stuff, so clarify that.
2. 
   DrahtBot commented at 2:10 pm on November 29, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake, pablomartin4btc
   Concept ACK	hernanmarino

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #26656 (tests: Improve runtime of some tests when --enable-debug by achow101)
   • #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Tests on Nov 29, 2022
4. 
   maflcko commented at 2:10 pm on November 29, 2022: member

   Removed it from the list in #20078 (comment)
5. 
   Sjors commented at 2:32 pm on November 29, 2022: member

   It also checks that older nodes still sync with new ones, though not in very interesting ways. But splitting it might be overkill.

   Since the bulk of the code checks wallet compatibility, I don’t mind renaming it. If we ever want to test more interesting (soft-fork / p2p) backwards compatibility we could also make a new test (which would ideally use MiniWallet).

6. maflcko renamed this:
   test: Move feature_backwards_compatibility.py to wallet_backwards_compatibility.py
   test: Move wallet tests to wallet_*.py
   on Nov 29, 2022
7. 
   maflcko commented at 4:37 pm on November 29, 2022: member

   Pushed to move two wallet tests to wallet_*.py, let me know if I forgot any
8. maflcko force-pushed on Nov 29, 2022
9. 
   hernanmarino commented at 4:04 pm on December 5, 2022: contributor

   ACK :+1:
10. 
    pablomartin4btc commented at 4:15 pm on December 5, 2022: member

    cr ACK. I see @Sjors’s point, I still agree with this change as I’m also following the upgrading of tests to MiniWallet usage and this change conveys that intention.
11. DrahtBot added the label Needs rebase on Dec 5, 2022
12. 
    pablomartin4btc commented at 9:48 pm on December 5, 2022: member

    Since we are here, perhaps you could move rpc_psbt.py to wallet_psbt.py as you mentioned here.
13. 
    maflcko commented at 12:20 pm on December 6, 2022: member

    Not sure, about half of it is testing the wallet, the other half not. Ideally the parts were split or the non-wallet parts wouldn’t depend on a wallet, so I’ll leave it for a follow-up for now.
14. maflcko force-pushed on Dec 6, 2022
15. DrahtBot removed the label Needs rebase on Dec 6, 2022
16. DrahtBot added the label Needs rebase on Dec 6, 2022
17. maflcko force-pushed on Dec 6, 2022
18. DrahtBot removed the label Needs rebase on Dec 6, 2022
19. DrahtBot added the label Needs rebase on Dec 9, 2022
20. test: Move feature_backwards_compatibility.py to wallet_backwards_compatibility.py fa933d6985
21. test: Move rpc_fundrawtransaction.py to wallet_fundrawtransaction.py fa7d71accc
22. maflcko force-pushed on Dec 9, 2022
23. DrahtBot removed the label Needs rebase on Dec 9, 2022
24. 
    maflcko commented at 12:12 pm on December 9, 2022: member

    rebased
25. fanquake approved
26. 
    fanquake commented at 1:37 pm on December 9, 2022: member

    ACK fa7d71acccab4e5b416c9dd1e2080a9652107f84
27. hernanmarino approved
28. pablomartin4btc approved
29. 
    pablomartin4btc commented at 3:11 pm on December 9, 2022: member

    re-ACK https://github.com/bitcoin/bitcoin/commit/fa7d71acccab4e5b416c9dd1e2080a9652107f84
30. maflcko merged this on Dec 9, 2022
31. maflcko closed this on Dec 9, 2022

    ---

32. maflcko deleted the branch on Dec 9, 2022
33. sidhujag referenced this in commit 7a3ae9eb68 on Dec 9, 2022
34. bitcoin locked this on Dec 9, 2023

Contributors
maflcko DrahtBot Sjors hernanmarino pablomartin4btc fanquake

Labels
Tests