doc: CalculateSequenceLocks: prevHeights entries are set to 0, not removed #26603

pull stickies-v wants to merge 1 commits into bitcoin:master from stickies-v:docs-fix-CalculateSequenceLocks changing 1 files +2 −2

stickies-v commented at 6:05 PM on November 29, 2022: contributor

In CalculateSequenceLocks no items are removed from prevHeights, they are just set to 0:

https://github.com/bitcoin/bitcoin/blob/a035b6a0c418d0b720707df69559028bd662fa70/src/consensus/tx_verify.cpp#L69-L73

This PR updates the docs to reflect the actual implementation. Seems to have been wrongly documented since introduction in #7184 already (implementation and documentation)
doc: fix: prevHeights entries are set to 0, not removed f537127271
DrahtBot commented at 6:05 PM on November 29, 2022: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Docs on Nov 29, 2022
hebasto approved
hebasto commented at 12:15 PM on November 30, 2022: member

ACK f537127271b1f22ee4651915b7b9266e0df72841
hebasto commented at 2:26 PM on December 3, 2022: member

OTOH, we could just avoid any side effects in the CalculateSequenceLocks() -- hebasto/221203-csl.
glozow merged this on Jan 4, 2023
glozow closed this on Jan 4, 2023
sidhujag referenced this in commit 029810869c on Jan 4, 2023
stickies-v deleted the branch on Mar 14, 2023
bitcoin locked this on Mar 13, 2024

Type	Reviewers
ACK	hebasto

Contributors

Labels

Linked (view graph)

#7184 Implement SequenceLocks functions for BIP 68

doc: CalculateSequenceLocks: prevHeights entries are set to 0, not removed #26603

Reviews