contrib: Add CFLAG env variable when MacOS version > 11.0.0 #26623

1. 
   shaavan commented at 9:47 am on December 2, 2022: contributor

   On Mac OS Version > 11.0.0, running ./contrib/install/db4.sh `pwd` on master leads to the following error. \

   0WARNING: NO SHARED LATCH IMPLEMENTATION FOUND FOR THIS PLATFORM.
   1configure: error: Unable to find a mutex implementation
   

   As documented in #20195, the reason for this error is that Apple has enabled -Werror=implicit-function-declaration by default.

   The fix noticed in that PR was to set CFLAGS to “-Wno-error=implicit-function-declaration”. This PR adds that fix to the contrib/install_db4.sh file so that it can run smoothly for Mac OS version > 11.0.0

2. contrib: Add CFLAG env variable when MacOS version > 11.0.0 cf51f61ef6
3. 
   DrahtBot commented at 9:47 am on December 2, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Scripts and tools on Dec 2, 2022
5. bitcoin deleted a comment on Dec 2, 2022
6. 
   maflcko commented at 10:00 am on December 2, 2022: member

   Wouldn’t it be better to just use brew, as explained in the docs: https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md#legacy-wallet-support

   0brew install berkeley-db@4
   

7. 
   jarolrod commented at 5:55 pm on December 2, 2022: member

   A user would have no issue installing bdb on macOS since it is easily accessible with a package manager, this script is really meant for cases where there is no bdb package readily accessible and the user wants to perform a dynamic build. Otherwise, just use depends.

   Nevertheless, this doesn’t seem to work as intended in my testing. On macOS 12.6 M1 I still run into the issue.

8. 
   fanquake commented at 9:33 am on December 5, 2022: member

   Agree on leaving this as-is. You can also set your CFLAGS before invoking the script, i.e CFLAGS=-Wno-error=implicit-function-declaration ./install_db4.sh.
9. fanquake closed this on Dec 5, 2022

   ---

10. fanquake referenced this in commit 74dd72013f on Jan 6, 2023
11. fanquake referenced this in commit 110e166e6b on Jan 6, 2023
12. fanquake referenced this in commit 2651472ed2 on Jan 17, 2023
13. fanquake referenced this in commit e20d10142e on Jan 17, 2023
14. fanquake referenced this in commit 44f3c7de21 on Jan 18, 2023
15. achow101 referenced this in commit 483a4bb819 on Jan 27, 2023
16. bitcoin locked this on Dec 5, 2023

Contributors
shaavan DrahtBot maflcko jarolrod fanquake

Labels
Scripts and tools