test: Run mempool_packages.py with MiniWallet #26625

1. 
   maflcko commented at 4:28 PM on December 2, 2022: member

   This allows to run the test even when no wallet is compiled in.

   Also, it is a lot nicer to read now.

2. 
   DrahtBot commented at 4:28 PM on December 2, 2022: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	glozow
   Concept ACK	0xB10C, theStack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   No conflicts as of last run.

3. maflcko renamed this:
   test: Run mempool_packages.py with MiniWallet
   test: Run mempool_packages.py with MiniWallet
   on Dec 2, 2022
4. DrahtBot renamed this:
   test: Run mempool_packages.py with MiniWallet
   test: Run mempool_packages.py with MiniWallet
   on Dec 2, 2022
5. DrahtBot added the label Tests on Dec 2, 2022
6. maflcko force-pushed on Dec 2, 2022
7. 
   0xB10C commented at 5:37 PM on December 2, 2022: contributor

   Concept ACK

8. fanquake requested review from glozow on Dec 4, 2022
9. DrahtBot added the label Needs rebase on Dec 5, 2022
10. maflcko force-pushed on Dec 6, 2022
11. maflcko force-pushed on Dec 6, 2022
12. maflcko force-pushed on Dec 6, 2022
13. DrahtBot removed the label Needs rebase on Dec 6, 2022
14. maflcko force-pushed on Dec 6, 2022
15. 
    theStack commented at 5:21 PM on December 6, 2022: contributor

    Concept ACK

16. maflcko force-pushed on Jan 3, 2023
17. in test/functional/test_framework/wallet.py:352 in fa39d8630c outdated

     360 | -    def send_self_transfer_chain(self, *, from_node, chain_length, utxo_to_spend=None):
     361 | +    def send_self_transfer_chain(self, *, from_node, **kwargs):
     362 |          """Create and send a "chain" of chain_length transactions. The nth transaction in
     363 |          the chain is a child of the n-1th transaction and parent of the n+1th transaction.
     364 |  
     365 |          Returns the chaintip (nth) utxo
    

    ---

    ---

    

    glozow commented at 11:47 AM on January 13, 2023:

    nit in fa39d8630c5888a9d432712addab5cff1bd44621:

    doc needs to be updated, as it no longer returns a utxo.

            Returns a list of objects for each tx (see create_self_transfer_multi).
    

    ---

    

    maflcko commented at 9:43 AM on January 17, 2023:

    thanks, fixed doc

18. in test/functional/mempool_packages.py:30 in fa834fa3d5 outdated

      26 | @@ -29,7 +27,7 @@
      27 |  
      28 |  class MempoolPackagesTest(BitcoinTestFramework):
      29 |      def add_options(self, parser):
      30 | -        self.add_wallet_options(parser)
      31 | +        self.add_wallet_options(parser, legacy=False)
    

    ---

    ---

    

    glozow commented at 12:38 PM on January 13, 2023:

    question, why legacy=False?

    ---

    

    maflcko commented at 9:43 AM on January 17, 2023:

    Thanks, dropped for now

19. 
    glozow commented at 12:41 PM on January 13, 2023: member

    utACK fa834fa3d5501214e6e98b57d046b85d6e8300c9, looks correct to me. one nit

20. DrahtBot added the label Needs rebase on Jan 16, 2023
21. test: Return wtxid from create_self_transfer_multi

    This is not used right now, but may be in the future. Also, it
    simplifies the create_self_transfer return logic

    fa2d82103f
22. test: Refactor MiniWallet sign_tx

    To make the code less verbose and easier to read.

    faa12d4ccd
23. test: Return chain of MiniWallet txs from MiniWallet chain method faec09f240
24. test: Return fee from MiniWallet fa448c27d2
25. test: Run mempool_packages.py with MiniWallet fa6b402114
26. maflcko force-pushed on Jan 17, 2023
27. DrahtBot removed the label Needs rebase on Jan 17, 2023
28. fanquake requested review from theStack on Jan 17, 2023
29. fanquake requested review from glozow on Jan 17, 2023
30. 
    glozow commented at 4:10 PM on January 17, 2023: member

    reACK fa6b402

31. fanquake merged this on Jan 17, 2023
32. fanquake closed this on Jan 17, 2023

    ---

33. maflcko deleted the branch on Jan 17, 2023
34. sidhujag referenced this in commit 3a5b3b87c2 on Jan 17, 2023
35. bitcoin locked this on Jan 17, 2024

Contributors

maflckoDrahtBot0xB10CtheStackglozow

Review Requested
theStackglozow