*_t types are not defined. Swap for unsigned int and unsigned char etc.
Update hash.cpp #2663
pull pshep wants to merge 1 commits into bitcoin:master from pshep:patch-1 changing 1 files +8 −8-
pshep commented at 5:30 PM on May 17, 2013: none
-
16ecc9e41f
Update hash.cpp
*_t types are not defined. Swap for unsigned int and unsigned char etc.
-
gmaxwell commented at 5:41 PM on May 17, 2013: contributor
This is the wrong thing to do. We need specific sizes for specific normative behavior in many places, not all systems use the same sizes for primitive types. The stdint.h _t named size types are standards specified by SUS and in C++11.
-
pshep commented at 6:01 PM on May 17, 2013: none
Ah right. Compiling for another platform and these aren't defined - throws errors. Searched the rest of the bitcoin code and saw no other instances of *_t being used. It's unique to this file (well, aside from LevelDB)
- pshep closed this on May 17, 2013
-
BitcoinPullTester commented at 6:11 PM on May 17, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/16ecc9e41f0f6c11c5848ac5b697a1354c12a1d1 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
luke-jr commented at 7:34 PM on May 17, 2013: member
Eventually, it would be nice to migrate everything bit-specific to the standard [u]intN_t types, but the last attempt to do so had some issues. In addition to C++11, stdint.h was also part of C99 (1999, over 13 years ago) - perhaps you can get the header that way somehow?
- DrahtBot locked this on Sep 8, 2021
Contributors