Fixes #26511
test: prefer sqlite for wallet tests #26638
pull S3RK wants to merge 2 commits into bitcoin:master from S3RK:wallet_test_prefer_sqlite changing 2 files +14 −24-
S3RK commented at 8:56 AM on December 5, 2022: contributor
-
DrahtBot commented at 8:56 AM on December 5, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK MarcoFalke, achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Tests on Dec 5, 2022
-
maflcko commented at 10:31 AM on December 5, 2022: member
Looks like you'll need to add a missing --legacy-wallet to the failing test?
-
test: make wallet_migration.py pass with both wallet flags 8e0fabaabf
-
test: prefer sqlite for wallet tests 17554efb60
- S3RK force-pushed on Dec 6, 2022
-
S3RK commented at 8:19 AM on December 6, 2022: contributor
Looks like you'll need to add a missing --legacy-wallet to the failing test?
Addressed this in a different (hopefully better way) by making
wallet_migration.pypass with both wallet flags -
maflcko commented at 8:24 AM on December 6, 2022: member
review ACK 17554efb6095f6ec273e52568efe1678253cb7c0
- fanquake requested review from achow101 on Dec 6, 2022
-
achow101 commented at 11:05 PM on December 20, 2022: member
ACK 17554efb6095f6ec273e52568efe1678253cb7c0
- achow101 referenced this in commit 8456bfac6b on Dec 20, 2022
- DrahtBot added the label Needs rebase on Dec 20, 2022
-
DrahtBot commented at 11:33 PM on December 20, 2022: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
-
achow101 commented at 11:35 PM on December 20, 2022: member
Github isn't detecting this as merged for some reason.
- achow101 closed this on Dec 20, 2022
- sidhujag referenced this in commit 8e3fb5a930 on Dec 21, 2022
- bitcoin locked this on Dec 20, 2023