24.0.1 final changes #26647

1. 
   fanquake commented at 12:50 pm on December 6, 2022: member

   Changes for 24.0.1.

   At this stage, I don’t think an rc is necessary here, and would just add another 5-x days delay to fixing these issues.

   This will be accompanied by a pull request to master to add a note in the 24.0.md that already exists there. Similar to what was done with 0.19.0.1.

2. build: bump version to 24.0.1 final 1b19c894a2
3. doc: generate manual pages for 24.0.1 final c119b0a176
4. doc: adjust release notes for 24.0.1

   This will be accompianied by a change to release-notes-24.0.md on
   master.

   a9ea715835
5. fanquake added this to the milestone 24.0.1 on Dec 6, 2022
6. 
   DrahtBot commented at 12:50 pm on December 6, 2022: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, josibake, gruve-p, instagibbs, w0xlt

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

7. DrahtBot added the label Backport on Dec 6, 2022
8. hebasto approved
9. 
   hebasto commented at 1:17 pm on December 6, 2022: member

   ACK a9ea7158351ad89f62a13335368df8cc54114f7f, I have reviewed the changes and they look OK.
10. in doc/man/bitcoin-cli.1:1 in c119b0a176 outdated

    0@@ -1,7 +1,7 @@
    1 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.2.
    

    ---

    ---

    

    josibake commented at 1:44 pm on December 6, 2022:

    not super familiar with this process, but im guessing modifying these files won’t cause any issues?

    ---

    

    fanquake commented at 2:08 pm on December 6, 2022:

    They are being modified to update the version numbers. The updating was done using help2man.
11. josibake approved
12. 
    josibake commented at 1:48 pm on December 6, 2022: member

    ACK https://github.com/bitcoin/bitcoin/pull/26647/commits/a9ea7158351ad89f62a13335368df8cc54114f7f

    lgtm, altho im assuming its okay to modify doc/man files because they are generated one time as part of creating the 24.x branch

13. 
    gruve-p commented at 2:39 pm on December 6, 2022: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/26647/commits/a9ea7158351ad89f62a13335368df8cc54114f7f
14. 
    instagibbs commented at 3:04 pm on December 6, 2022: member

    ACK https://github.com/bitcoin/bitcoin/pull/26647/commits/a9ea7158351ad89f62a13335368df8cc54114f7f
15. w0xlt approved
16. 
    w0xlt commented at 3:17 pm on December 6, 2022: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/26647/commits/a9ea7158351ad89f62a13335368df8cc54114f7f
17. MarcoFalke merged this on Dec 6, 2022
18. MarcoFalke closed this on Dec 6, 2022

    ---

19. fanquake deleted the branch on Dec 6, 2022
20. MarcoFalke deleted a comment on Jan 28, 2023
21. MarcoFalke locked this on Jan 28, 2023

Contributors
fanquake DrahtBot hebasto josibake gruve-p instagibbs w0xlt

Labels
Backport

Milestone
24.0.1