refactor: make some BlockManager members const #26664

1. 
   promag commented at 4:11 pm on December 8, 2022: member

   These methods can be const so make them const 🤷
2. refactor: ComputeUTXOStats receives const BlockManager& d0efa0c453
3. refactor: make BlockManager::IsBlockPruned const d888624207
4. refactor: make BlockManager::GetLastCheckpoint const 5d659fff70
5. refactor: make BlockManager::GetFirstStoredBlock const c4ecddd25a
6. 
   DrahtBot commented at 4:11 pm on December 8, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept ACK	TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #26533 (prune: scan and unlink already pruned block files on startup by andrewtoth)
   • #26415 (rpc,rest,zmq: faster getblock, NotifyBlock and rest_block by reading raw block by andrewtoth)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. DrahtBot added the label Refactoring on Dec 8, 2022
8. 
   fanquake commented at 4:14 pm on December 8, 2022: member

   See also #25673, which came with the CI check.
9. 
   promag commented at 9:29 pm on December 13, 2022: member

   @fanquake d0efa0c4537b65c0f8ec12d4d9df56df3f9e1283 is the motivation for this change, making blockman usage const.
10. 
    TheCharlatan commented at 10:04 pm on February 17, 2023: contributor

    Concept ACK

    It won’t make a difference to any callers of the BlockManager, but I think you could mark FlushUndoFile as const as well.

11. DrahtBot added the label Needs rebase on Feb 28, 2023
12. 
    DrahtBot commented at 3:45 pm on February 28, 2023: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

13. 
    achow101 commented at 4:26 pm on April 25, 2023: member

    The feature request didn’t seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

    Closing due to lack of interest. Pull requests with improvements are always welcome.

14. achow101 closed this on Apr 25, 2023

    ---

15. bitcoin locked this on Apr 24, 2024

Contributors
promag DrahtBot fanquake TheCharlatan achow101

Labels
Refactoring Needs rebase