For wallets that only have one output type, we are currently performing the same selection process over the same coins twice.
The "mixed coin selection" doesn't add any value to the result (there is nothing to mix if the available coins struct has only one type).
there is nothing to mix.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | john-moffett, achow101, kristapsk |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
ACK 89c1491d35389eac0c1fecc59333cdfae3b1bd2c
It's not important to this code, but this comment:
// If TypesCount() <= 1, there is nothing to mix.
got me wondering whether you could get to here with TypesCount() == 0, and I don't think you can, due to https://github.com/bitcoin/bitcoin/blob/6061eb6564105ad54703a7cf3282590d0e1a7f28/src/wallet/spend.cpp#L599-L605
Yes @john-moffett, if TypesCount() == 0 then we have no coins, so we never perform coin selection.
ACK 89c1491d35389eac0c1fecc59333cdfae3b1bd2c
cr utACK 89c1491d35389eac0c1fecc59333cdfae3b1bd2c