build: Update libmultiprocess library #26672

1. 
   hebasto commented at 2:59 pm on December 9, 2022: member

   This update in particular includes:

   • https://github.com/chaincodelabs/libmultiprocess/pull/78 which is required for #25972
   • https://github.com/chaincodelabs/libmultiprocess/pull/74
   • https://github.com/chaincodelabs/libmultiprocess/pull/70
2. 
   DrahtBot commented at 2:59 pm on December 9, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	ryanofsky

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Build system on Dec 9, 2022
4. in depends/packages/libmultiprocess.mk:27 in 2a2dd0a80c outdated

   23@@ -24,5 +24,5 @@ define $(package)_build_cmds
   24 endef
   25 
   26 define $(package)_stage_cmds
   27-  $(MAKE) DESTDIR=$($(package)_staging_dir) install
   28+  $(MAKE) DESTDIR=$($(package)_staging_dir) install-lib
   

   ---

   ---

   

   ryanofsky commented at 3:19 pm on December 9, 2022:

   In commit “build: Update libmultiprocess library” (2a2dd0a80c61792ad30a7814dff55a9d46391d91)

   Note for reviewers: replacing install with install-lib and install-bin here isn’t strictly necessary just to update the library, but it takes advantage of recent changes in the new version, and makes the build more minimal.

   (This could be noted in the commit message, too.)

   ---

   

   hebasto commented at 3:27 pm on December 9, 2022:

   This could be noted in the commit message, too.

   Thanks! The commit message has been updated.

5. ryanofsky approved
6. 
   ryanofsky commented at 3:22 pm on December 9, 2022: contributor

   Code review ACK 2a2dd0a80c61792ad30a7814dff55a9d46391d91.

   Thanks for the version update. I do want to look into converting the library into a subtree so this step isn’t necessary in the future.

7. build: Update `libmultiprocess` library

   Replacing `install` with `install-lib` and `install-bin` is not strictly
   necessary just to update the library, but it takes advantage of recent
   changes in the new version, and makes the build more minimal.

   1986f129c6
8. hebasto force-pushed on Dec 9, 2022
9. 
   hebasto commented at 3:30 pm on December 9, 2022: member

   Updated 2a2dd0a80c61792ad30a7814dff55a9d46391d91 -> 1986f129c6af7644d238c76f032713731d7afcac (pr26672.01 -> pr26672.02, diff):

   • addressed @ryanofsky’s comment
10. ryanofsky approved
11. 
    ryanofsky commented at 5:43 pm on December 9, 2022: contributor

    Code review ACK 1986f129c6af7644d238c76f032713731d7afcac

    Just updated commit message since last review (thanks!)

12. fanquake merged this on Dec 10, 2022
13. fanquake closed this on Dec 10, 2022

    ---

14. hebasto deleted the branch on Dec 10, 2022
15. sidhujag referenced this in commit e603e70e7a on Dec 10, 2022
16. bitcoin locked this on Dec 10, 2023

Contributors
hebasto DrahtBot ryanofsky

Labels
Build system