Closes #26667
To be eligible for fee-bumping, a transaction must not have any of its outputs (eg - change) spent in other unconfirmed transactions in the wallet. This behavior is currently enforced and tested.
However, this check shouldn’t apply to spends in abandoned descendant transactions, as explained by #26667.
CWallet::IsSpent already carves out an exception for abandoned transactions, so we can just use that.
I’ve also added a new test to cover this case.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
293+ # Find change output
294+ output_list = rbf_node.getrawtransaction(parent_id, 1)["vout"]
295+ change_output = next(o for o in output_list if o["value"] == Decimal("0.00049000"))
296+
297+ # Submit child transaction with low fee
298+ child = rbf_node.createrawtransaction([{"txid": parent_id, "vout": change_output["n"]}], {dest_address: 0.0004850})
send RPC?
send is marked as “EXPERIMENTAL warning: this call may be changed in future releases”. I do see other uses of it in tests, though.
send and it did end up simplifying the test code a bit. Thanks!
utACK 7c325c28372d75f32425f9d35d455b2d5750d4b8
(I also checked that the test fails without the change in HasWalletSpend())
To be eligible for fee-bumping, a transaction must not have any
of its outputs (eg - change) spent in other unconfirmed transactions
in the wallet. However, this check should not apply to abandoned
transactions.
A new test case is added to cover this case.
