following https://github.com/bitcoin/bitcoin/pull/26480/commits/555519d082fbe5e047595f06d7f301e441bb7149, TestShell now always runs with -disablewallet. simple fix is to add add_wallet_options to add_options; looks like testshell was overlooked when adding in the add_wallet_options call to the functional tests in #26480
test: add add_wallet_options to TestShell #26689
pull josibake wants to merge 1 commits into bitcoin:master from josibake:josibake-add-wallet-options-test-shell changing 1 files +3 −0-
josibake commented at 5:02 PM on December 12, 2022: member
-
bcb7123406
test: add add_wallet_options to TestShell
without this, testShell runs with -disablewallet
-
DrahtBot commented at 5:02 PM on December 12, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK amitiuttarwar If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Dec 12, 2022
- josibake referenced this in commit 555519d082 on Dec 12, 2022
-
amitiuttarwar commented at 9:47 PM on December 13, 2022: contributor
ACK bcb71234065e525e9f3cccceaaab320f2ec3741b
- maflcko merged this on Dec 14, 2022
- maflcko closed this on Dec 14, 2022
- sidhujag referenced this in commit 613011b464 on Dec 14, 2022
- bitcoin locked this on Dec 14, 2023
- josibake deleted the branch on Jan 26, 2024
Contributors
Labels