minrelaytxfee doesn’t accept 0 #2673

issue ghost openend this issue on May 19, 2013
  1. ghost commented at 10:32 pm on May 19, 2013: none

    Using -minrelaytxfee or minrelaytxfee in bitcoin.conf results in:

    Error: Invalid amount for -minrelaytxfee=: ‘0’

  2. Diapolo commented at 3:41 pm on May 20, 2013: none
    No error, it just has to be > 0, as the code checks for that condition currently.
  3. gmaxwell commented at 7:08 pm on May 20, 2013: contributor
    Zero doesn’t make sense here, since free transactions are handled separately. 0.00000001 does, though it’s probably not an actually good value right now, as it would make it easy for someone connected to you to run you out of memory.
  4. gavinandresen commented at 11:11 pm on May 20, 2013: contributor

    I asked LaserMissile to open this bug. It’d be nice if =0 carried out the user’s intent, requiring =0.00000001 to mean “relay anything” isn’t friendly.

    (yes, setting it that low is dumb and might make you vulnerable to a DoS attack, but I think it is important to let users shoot themselves in their feet as long as it is not easy to do accidently).

    PS: when fixing, be sure to test: =0 =0.0 and =0,1 (should error) and =eleven (should error).

  5. gmaxwell commented at 11:14 pm on May 20, 2013: contributor
    Ah, that sounds great to me.
  6. thisisgil commented at 11:43 pm on May 30, 2013: none
    Just out of curiosity - can any give me a simplified explanation of the vector in which a user submitting a tx fee of one satoshi opens themselves up to DoS?
  7. laanwj added the label Feature on Feb 9, 2016
  8. laanwj removed the label Refactoring on Feb 9, 2016
  9. MarcoFalke commented at 2:01 pm on February 12, 2017: member
    One of the commits in #9602 solves this issue.
  10. laanwj closed this on Mar 7, 2017

  11. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-05 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me