This PR adds test coverage for the following error: https://github.com/bitcoin/bitcoin/blob/6d40a1a7e7f09ff2c32e53237f968adf8300d028/src/wallet/rpc/wallet.cpp#L275-L277
https://marcofalke.github.io/btc_cov/total.coverage/src/wallet/rpc/wallet.cpp.gcov.html
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | aureleoules |
| Concept ACK | kevkevinpal |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Tested ACK
tested on my local machine
git log -1
commit 3666a06730b2229e5af24124e6ef0403e4a6792e (HEAD -> PR26738)
Author: brunoerg <brunoely.gc@gmail.com>
Date: Wed Dec 21 11:03:24 2022 -0300
test: add coverage for unknown wallet flag in `setwalletflag`
test/functional/wallet_avoidreuse.py
2022-12-24T17:08:09.612000Z TestFramework (INFO): Initializing test directory /var/folders/9g/cvx014yx4dq5lwl_x5zvn_j80000gn/T/bitcoin_func_test_bo0btz_x
2022-12-24T17:08:11.499000Z TestFramework (INFO): Test wallet files persist avoid_reuse flag
2022-12-24T17:08:12.315000Z TestFramework (INFO): Test immutable wallet flags
2022-12-24T17:08:13.502000Z TestFramework (INFO): Test that change doesn't turn into non-change when spent
2022-12-24T17:08:13.568000Z TestFramework (INFO): Test sending from reused address with avoid_reuse=false
2022-12-24T17:08:14.647000Z TestFramework (INFO): Test sending from reused legacy address fails
2022-12-24T17:08:14.695000Z TestFramework (INFO): Test sending from reused p2sh-segwit address fails
2022-12-24T17:08:14.726000Z TestFramework (INFO): Test sending from reused bech32 address fails
2022-12-24T17:08:14.761000Z TestFramework (INFO): Test getbalances used category
2022-12-24T17:08:15.988000Z TestFramework (INFO): Test that full destination groups are preferred in coin selection
2022-12-24T17:08:16.545000Z TestFramework (INFO): Test that all destination groups are used
2022-12-24T17:08:18.862000Z TestFramework (INFO): Stopping nodes
2022-12-24T17:08:19.243000Z TestFramework (INFO): Cleaning up /var/folders/9g/cvx014yx4dq5lwl_x5zvn_j80000gn/T/bitcoin_func_test_bo0btz_x on exit
2022-12-24T17:08:19.244000Z TestFramework (INFO): Tests successful
ACK 3666a06730b2229e5af24124e6ef0403e4a6792e