Unable to open descriptor wallets that are not in a wallet directory #26739

issue achow101 openend this issue on December 21, 2022
  1. achow101 commented at 10:19 pm on December 21, 2022: member

    A user reported on IRC that they were unable to open a descriptor wallet that they had in their walletdir as a file, not as a wallet directory. Since we expect descriptor wallets to always be in a wallet directory, this resulted in them being unable to use their wallet until they moved it into a directory. IIRC the it was an intentional decision to impose this restriction for descriptor wallets because we would only be creating new wallets which would create wallets in the expected directories following the expected wallet directory format. Since descriptor wallets were wholly new, there was no expectation that we would need the backwards compatibility feature of being able to open wallets that are not contained within a wallet directory.

    But given that this has had an impact on some users, should we allow users to specify wallets in this way?

    It’s important to remember that this feature only exists for legacy wallets because of how multiwallet was originally implemented. The intention was only to not remove backwards compatibility for wallets created with the original multiwallet implementation, not as a proper feature. But it seems that some users (and third party application developers) are using this as if it were an intended and expected feature.

    I’m pretty sure there was some discussion in #19077 about this, but it’s a big PR and I can’t find the comments.

  2. achow101 added the label Brainstorming on Dec 21, 2022
  3. achow101 added the label Wallet on Dec 21, 2022
  4. pablomartin4btc commented at 12:32 pm on June 26, 2023: contributor
    I think it could be this one? Commented by @ryanofsky, “Future flexibility” bullet point, and your response to him here. I could work on it if you both are happy with it since I do also agree with that feature. Cheers!
  5. achow101 commented at 3:30 pm on June 26, 2023: member

    I could work on it if you both are happy with it since I do also agree with that feature.

    I’m not sure that this is something that we should implement. This issue is primarily for brainstorming and comment gathering.

  6. pablomartin4btc commented at 12:32 pm on July 1, 2023: contributor

    I’m not sure that this is something that we should implement. This issue is primarily for brainstorming and comment gathering.

    I understand, and just for my own sake, I’d need to play around with the code and see how it behaves respect to the issues described above in @ryanofsky’s comment, plus the “downgrading issues” discussion between both of you, and also the conversations around situations detailed on both PRs #1889 and #11687.

  7. willcl-ark commented at 3:55 pm on September 21, 2023: contributor

    The feature request didn’t seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

    Pull requests with improvements are always welcome.

  8. willcl-ark closed this on Sep 21, 2023


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-29 07:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me