doc: Correct linked Microsoft URLs #26771

pull suriyaa wants to merge 1 commits into bitcoin:master from suriyaa:build-windows changing 5 files +10 −10
  1. suriyaa commented at 7:09 PM on December 29, 2022: contributor

    Update Microsoft-related links.

  2. DrahtBot commented at 7:09 PM on December 29, 2022: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Stale ACK hebasto, kiminuo, 1440000bytes, w0xlt

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Dec 29, 2022
  4. in build_msvc/README.md:72 in 2d7553f7d9 outdated
      68 | @@ -69,7 +69,7 @@ Alternatively, open the `build_msvc/bitcoin.sln` file in Visual Studio.
      69 |  
      70 |  Security
      71 |  ---------------------
      72 | -[Base address randomization](https://docs.microsoft.com/en-us/cpp/build/reference/dynamicbase-use-address-space-layout-randomization?view=msvc-160) is used to make Bitcoin Core more secure. When building Bitcoin using the `build_msvc` process base address randomization can be disabled by editing `common.init.vcproj` to change `RandomizedBaseAddress` from `true` to `false` and then rebuilding the project.
      73 | +[Base address randomization](https://learn.microsoft.com/en-us/cpp/build/reference/dynamicbase-use-address-space-layout-randomization?view=msvc-160) is used to make Bitcoin Core more secure. When building Bitcoin using the `build_msvc` process base address randomization can be disabled by editing `common.init.vcproj` to change `RandomizedBaseAddress` from `true` to `false` and then rebuilding the project.
    


    hebasto commented at 7:17 PM on December 29, 2022:

    No need to specify the exact VS version. This will point at the latest one:

    [Base address randomization](https://learn.microsoft.com/en-us/cpp/build/reference/dynamicbase-use-address-space-layout-randomization) is used to make Bitcoin Core more secure. When building Bitcoin using the `build_msvc` process base address randomization can be disabled by editing `common.init.vcproj` to change `RandomizedBaseAddress` from `true` to `false` and then rebuilding the project.
    

    suriyaa commented at 7:56 PM on December 29, 2022:

    ✔️ Removed exact VS version in build_msvc/README.md.

  5. in src/bench/nanobench.h:1908 in 2d7553f7d9 outdated
    1904 | @@ -1905,7 +1905,7 @@ PerformanceCounters& performanceCounters() {
    1905 |  // Windows version of doNotOptimizeAway
    1906 |  // see https://github.com/google/benchmark/blob/master/include/benchmark/benchmark.h#L307
    1907 |  // see https://github.com/facebook/folly/blob/master/folly/Benchmark.h#L280
    1908 | -// see https://docs.microsoft.com/en-us/cpp/preprocessor/optimize
    1909 | +// see https://learn.microsoft.com/en-us/cpp/preprocessor/optimize?view=msvc-170
    


    hebasto commented at 7:21 PM on December 29, 2022:

    No need to specify the exact VS version. This will point at the latest one:

    // see https://learn.microsoft.com/en-us/cpp/preprocessor/optimize
    

    suriyaa commented at 7:57 PM on December 29, 2022:

    ✔️ Removed exact VS version in src/bench/nanobench.h.

  6. in src/secp256k1/examples/random.h:16 in 2d7553f7d9 outdated
      12 | @@ -13,7 +13,7 @@
      13 |   * macOS   -> `getentropy(2)`(`sys/random.h`), if not available `/dev/urandom` should be used. https://www.unix.com/man-page/mojave/2/getentropy, https://opensource.apple.com/source/xnu/xnu-517.12.7/bsd/man/man4/random.4.auto.html
      14 |   * FreeBSD -> `getrandom(2)`(`sys/random.h`), if not available `kern.arandom` should be used. https://www.freebsd.org/cgi/man.cgi?query=getrandom, https://www.freebsd.org/cgi/man.cgi?query=random&sektion=4
      15 |   * OpenBSD -> `getentropy(2)`(`unistd.h`), if not available `/dev/urandom` should be used. https://man.openbsd.org/getentropy, https://man.openbsd.org/urandom
      16 | - * Windows -> `BCryptGenRandom`(`bcrypt.h`). https://docs.microsoft.com/en-us/windows/win32/api/bcrypt/nf-bcrypt-bcryptgenrandom
      17 | + * Windows -> `BCryptGenRandom`(`bcrypt.h`). https://learn.microsoft.com/en-us/windows/win32/api/bcrypt/nf-bcrypt-bcryptgenrandom
    


    hebasto commented at 7:24 PM on December 29, 2022:

    This change must be dropped from this PR, as it touches a subtree. This proposal could be submitted to https://github.com/bitcoin-core/secp256k1.


    suriyaa commented at 7:58 PM on December 29, 2022:

    ✖️ Dropped code change in src/secp256k1/examples/random.h.

  7. hebasto commented at 7:25 PM on December 29, 2022: member

    Approach ACK 2d7553f7d96392284ae24a82c29b34bd480b78c9.

  8. suriyaa force-pushed on Dec 29, 2022
  9. suriyaa requested review from hebasto on Dec 29, 2022
  10. in doc/build-windows.md:10 in e0fd750957 outdated
       5 | @@ -6,8 +6,8 @@ Below are some notes on how to build Bitcoin Core for Windows.
       6 |  The options known to work for building Bitcoin Core on Windows are:
       7 |  
       8 |  * On Linux, using the [Mingw-w64](https://www.mingw-w64.org/) cross compiler tool chain.
       9 | -* On Windows, using [Windows Subsystem for Linux (WSL)](https://docs.microsoft.com/windows/wsl/about) and Mingw-w64.
      10 | -* On Windows, using [Microsoft Visual Studio](https://www.visualstudio.com). See [README.md](/build_msvc/README.md).
      11 | +* On Windows, using [Windows Subsystem for Linux (WSL)](https://learn.microsoft.com/en-us/windows/wsl/about) and Mingw-w64.
      12 | +* On Windows, using [Microsoft Visual Studio](https://visualstudio.microsoft.com/). See [README.md](/build_msvc/README.md).
    


    kiminuo commented at 8:44 PM on December 29, 2022:

    Is the trailing slash necessary? It does not seem to be.


    suriyaa commented at 3:55 PM on December 31, 2022:

    ✔️ Trailing slash has been removed.

  11. hebasto approved
  12. hebasto commented at 8:44 PM on December 29, 2022: member

    ACK e0fd750957032548e78520985b53f9d0ee3f3766, I've verified all adjusted links by following them.

  13. in doc/fuzzing.md:286 in e0fd750957 outdated
     282 | @@ -283,7 +283,7 @@ $ sudo apt-get install libtool libtool-bin wget automake autoconf bison gdb
     283 |  ```
     284 |  
     285 |  At this point, you must install the .NET core.  The process differs, depending on your Linux distribution.
     286 | -See [this link](https://docs.microsoft.com/en-us/dotnet/core/install/linux) for details.
     287 | +See [this link](https://learn.microsoft.com/en-us/dotnet/core/install/linux) for details.
    


    kiminuo commented at 8:48 PM on December 29, 2022:

    (Unrelated but I think people tend to write "Ubuntu 20.04" and not "ubuntu 20.04" but I may be wrong.)


    suriyaa commented at 3:55 PM on December 31, 2022:

    ✏️ Correct spelling in line 287. Thank you for pointing this out. 😄

  14. kiminuo approved
  15. kiminuo commented at 8:51 PM on December 29, 2022: contributor

    ACK e0fd750, I tried all links and they work for me.

  16. unknown approved
  17. unknown commented at 9:43 PM on December 29, 2022: none

    ACK https://github.com/bitcoin/bitcoin/pull/26771/commits/e0fd750957032548e78520985b53f9d0ee3f3766

    Although the only change that looks important is L20 for vcpkg. Microsoft is known for using several domains and sub-domains for something. 301 redirections are also common like outlook.com to outlook.live.com

  18. w0xlt approved
  19. in build_msvc/README.md:20 in e0fd750957 outdated
      16 | @@ -17,7 +17,7 @@ Building with Visual Studio is an alternative to the Linux based [cross-compiler
      17 |  Prerequisites
      18 |  ---------------------
      19 |  To build [dependencies](../doc/dependencies.md) (except for [Qt](#qt)),
      20 | -the default approach is to use the [vcpkg](https://docs.microsoft.com/en-us/cpp/vcpkg) package manager from Microsoft:
      21 | +the default approach is to use the [vcpkg](https://vcpkg.io/en/index.html) package manager from Microsoft:
    


    brunoerg commented at 12:08 PM on December 30, 2022:

    nit: I think only https://vcpkg.io/ could be enough, I think it points to /en/index.html.

    the default approach is to use the [vcpkg](https://vcpkg.io/) package manager from Microsoft:
    

    suriyaa commented at 3:56 PM on December 31, 2022:

    ✔️ Updated the link. Thank you very much!

  20. doc: Correct linked Microsoft URLs f84e445dee
  21. suriyaa force-pushed on Dec 31, 2022
  22. fanquake merged this on Jan 4, 2023
  23. fanquake closed this on Jan 4, 2023

  24. suriyaa deleted the branch on Jan 4, 2023
  25. sidhujag referenced this in commit 1f0973f4a4 on Jan 4, 2023
  26. bitcoin locked this on Jan 4, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me