contrib: fix sha256 check in install_db4.sh for FreeBSD #26772

1. 
   murrayn commented at 7:33 am on December 30, 2022: contributor

   The FreeBSD version of sha256sum takes different arguments than the GNU version.

   The sha256_check function in contrib/install_db4.sh has code specific to FreeBSD, however it doesn’t get reached because while the sha256sum command does exist on FreeBSD, it is incompatible and results in an error:

   0sha256sum: option requires an argument -- c
   1usage: sha256sum [-pqrtx] [-c file] [-s string] [files ...]
   

   This change moves the FreeBSD-specific code before the check for the sha256sum command.

   Fixes: #26774

2. use sha256 command instead of sha256sum on FreeBSD 22e9afe40d
3. 
   DrahtBot commented at 7:33 am on December 30, 2022: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Consensus on Dec 30, 2022
5. 
   maflcko commented at 9:18 am on December 30, 2022: member

   No objection, but I wonder if this script can be replaced by a call to compile BDB in depends?
6. maflcko approved
7. 
   fanquake commented at 2:43 pm on December 30, 2022: member

   No objection, but I wonder if this script can be replaced by a call to compile BDB in depends?

   I think this is something we should at some point, and remove install_db4.sh entirely. We have already been removing it’s usage.

8. maflcko renamed this:
   script: fix sha256 check in contrib/install_db4.sh for FreeBSD
   contrib: fix sha256 check in install_db4.sh for FreeBSD
   on Dec 30, 2022
9. maflcko removed the label Consensus on Dec 30, 2022
10. DrahtBot added the label Scripts and tools on Dec 30, 2022
11. fanquake merged this on Jan 4, 2023
12. fanquake closed this on Jan 4, 2023

    ---

13. sidhujag referenced this in commit f1e347e9c8 on Jan 4, 2023
14. murrayn deleted the branch on Feb 17, 2023
15. bitcoin locked this on Feb 17, 2024

Contributors
murrayn DrahtBot maflcko fanquake

Labels
Scripts and tools