contrib: fix sha256 check in install_db4.sh for FreeBSD #26772

pull murrayn wants to merge 1 commits into bitcoin:master from murrayn:freebsd_db4_fix changing 1 files +7 −8

murrayn commented at 7:33 AM on December 30, 2022: contributor
The FreeBSD version of sha256sum takes different arguments than the GNU version.

The sha256_check function in contrib/install_db4.sh has code specific to FreeBSD, however it doesn't get reached because while the sha256sum command does exist on FreeBSD, it is incompatible and results in an error:
```
sha256sum: option requires an argument -- c
usage: sha256sum [-pqrtx] [-c file] [-s string] [files ...]
```
This change moves the FreeBSD-specific code before the check for the sha256sum command.

Fixes: #26774
use sha256 command instead of sha256sum on FreeBSD 22e9afe40d
DrahtBot commented at 7:33 AM on December 30, 2022: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
DrahtBot added the label Consensus on Dec 30, 2022
murrayn cross-referenced this on Dec 30, 2022 from issue contrib/install_db4.sh script fails on FreeBSD by murrayn
maflcko commented at 9:18 AM on December 30, 2022: member

No objection, but I wonder if this script can be replaced by a call to compile BDB in depends?
maflcko cross-referenced this on Dec 30, 2022 from issue doc: FreeBSD build doc updates to reflect removal of install_db4.sh by murrayn
maflcko approved
fanquake commented at 2:43 PM on December 30, 2022: member

No objection, but I wonder if this script can be replaced by a call to compile BDB in depends?

I think this is something we should at some point, and remove install_db4.sh entirely. We have already been removing it's usage.
maflcko renamed this:
~~script: fix sha256 check in contrib/install_db4.sh for FreeBSD~~
contrib: fix sha256 check in install_db4.sh for FreeBSD
on Dec 30, 2022
maflcko removed the label Consensus on Dec 30, 2022
DrahtBot added the label Scripts and tools on Dec 30, 2022
jonatack cross-referenced this on Dec 31, 2022 from issue Having trouble compiling the tests by blueredpen
fanquake merged this on Jan 4, 2023
fanquake closed this on Jan 4, 2023
sidhujag referenced this in commit f1e347e9c8 on Jan 4, 2023
jonatack cross-referenced this on Jan 9, 2023 from issue contrib/install_db4.sh script fails on OpenBSD 7.2 (RPi 3) (error: Unable to find a mutex implementation) by m-kubik
murrayn deleted the branch on Feb 17, 2023
bitcoin locked this on Feb 17, 2024

Contributors

Labels

Linked (view graph)

#26773 doc: FreeBSD build doc updates to reflect removal of install_db4.sh #26774 contrib/install_db4.sh script fails on FreeBSD #26860 contrib/install_db4.sh script fails on OpenBSD 7.2 (RPi 3) (error: Unable to find a mutex implementation)

contrib: fix sha256 check in install_db4.sh for FreeBSD #26772

Reviews