ci: Revert tsan task changes #26775

pull maflcko wants to merge 3 commits into bitcoin:master from maflcko:2212-tsan-revert-🎨 changing 3 files +8 −5
  1. maflcko commented at 8:52 am on December 30, 2022: member
    Looks like there are still bugs in clang-15, so we need to roll back all the way to the previously used version (clang-13).
  2. Revert "test: Drop no longer needed `race:epoll_ctl` TSan suppression" 
    This reverts commit a3f5e541523a843e834df1858e16f89188fe19a2.
    faa835e7e5
  3. Revert "ci: Use clang-15 in tsan task" 
    This reverts commit faa00ca78e27a40cbafe701348e6b3674e3ddeed.
    fa5d9a0e24
  4. ci: Remove duplicate CC and CXX from tsan task fabb6af850
  5. DrahtBot commented at 8:52 am on December 30, 2022: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  6. DrahtBot added the label Tests on Dec 30, 2022
  7. hebasto approved
  8. hebasto commented at 9:10 am on December 30, 2022: member
    ACK fabb6af8508a9c0d05d2e9f0006b0b1d3f38119a, I have reviewed the code and it looks OK, I agree it can be merged.
  9. fanquake commented at 9:50 am on December 30, 2022: member

    Can we revert just #26759? Is there an issue with using Clang-15 with the suppression back in place?

    Going forward, we should probably have better rationale for removing (already marked intermittent) suppresions, than “it works on my machine” and/or assuming it was magically fixed by some toolchain backport (which couldn’t have been the case here anyway).

    We should also figure out what is different about the Cirrus env; as the suppressed issue re-appeared immediately after the merge of #26759.

  10. maflcko commented at 10:00 am on December 30, 2022: member

    There are two unrelated issues:

    • The issue with clang-14/15 is an internal crash in tsan.
    • The tsan false positive.

    It doesn’t help that both are intermittent and the false positive is not reproducible so far. (I tried with a 4.15.0-173-generic kernel and another on 6.0.15)

  11. maflcko commented at 11:11 am on December 30, 2022: member

    We should also figure out what is different about the Cirrus env

    As the issues are intermittent, my best guess would be they are easier to reproduce on cloud providers with 3rd-party load on neighbouring CPUs or neighbouring threads on the same CPU.

  12. maflcko commented at 9:10 am on January 1, 2023: member

    There is also a third (unrelated?) issue:

    0Remaining jobs: [interface_bitcoin_cli.py --legacy-wallet]
1............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
2Timed out!
  13. maflcko merged this on Jan 1, 2023
  14. maflcko closed this on Jan 1, 2023
  15. maflcko deleted the branch on Jan 1, 2023
  16. sidhujag referenced this in commit ac9c1bfb8b on Jan 1, 2023
  17. maflcko commented at 1:06 pm on January 12, 2023: member

    I made some progress reproducing on a fresh install of Ubuntu Jammy:

    • Install packages and clone repos
    0apt update && apt install -y git vim htop ccache build-essential libtool autotools-dev automake pkg-config bsdmainutils python3 libevent-dev libboost-dev clang llvm libsqlite3-dev cmake ninja-build lld && ( git clone https://github.com/bitcoin/bitcoin  ./bitcoin-core && cd bitcoin-core/ && ./autogen.sh ) && git clone https://github.com/llvm/llvm-project && cd ./llvm-project/
    • Start bisect
    0git bisect start e0efedd2c33 88e66f
    • Run tests
    0( rm -rf build/ && ccache --zero-stats && mkdir build && cd build/ && cmake -G Ninja -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DLLVM_USE_LINKER=lld -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++  -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_INCLUDE_BENCHMARKS=OFF -DLLVM_INCLUDE_TESTS=OFF -DLLVM_PARALLEL_LINK_JOBS=1 -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS='clang;compiler-rt' ../llvm/ && ninja && ccache --show-stats && git log -1 && ./bin/clang --version ) && ( cd ../bitcoin-core/ && ./configure --disable-tests --disable-bench --disable-fuzz-binary --without-bdb --with-gui=no  --with-sanitizers=thread CC=/root/llvm-project/build/bin/clang CXX=/root/llvm-project/build/bin/clang++ && rm -f /tmp/runs && make clean && make -j $(nproc)  && ( strings /root/bitcoin-core/src/bitcoind |grep llvm/llvm-proje ) && while ( TSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/tsan:halt_on_error=1" ./test/functional/test_runner.py -j30   $(for i in $(seq 1 481); do echo 'interface_bitcoin_cli.py' ; done)    --failfast --timeout-factor=1 ) ; do echo 1 >> /tmp/runs ; done )

    (Then figure out whether to git bisect good or bad, based on the number of successful runs or a timeout/crash of bitcoind)

  18. maflcko commented at 3:46 pm on January 12, 2023: member 
     0llvm-project# git bisect bad
 19fb8058a8079b3a9a8af0aff0f4b6898960d331f is the first bad commit
 2commit 9fb8058a8079b3a9a8af0aff0f4b6898960d331f
 3Author: Dmitry Vyukov <dvyukov@google.com>
 4Date:   Mon Dec 13 12:45:53 2021 +0100
 5
 6    tsan: enable the new runtime
 7    
 8    This enables the new runtime (D112603) by default.
 9    
10    Depends on D112603.
11    
12    Differential Revision: https://reviews.llvm.org/D115624
13
14 compiler-rt/lib/tsan/CMakeLists.txt | 2 +-
15 1 file changed, 1 insertion(+), 1 deletion(-)

    See https://github.com/llvm/llvm-project/commit/9fb8058a8079b3a9a8af0aff0f4b6898960d331f and the previous commit https://github.com/llvm/llvm-project/commit/b332134921b42796c6b46453eaf2affdc09e3154

  20. fanquake referenced this in commit 220008604f on Mar 28, 2023
  21. sidhujag referenced this in commit 7083206493 on Mar 28, 2023
  22. bitcoin locked this on Jan 12, 2024


maflcko DrahtBot hebasto fanquake

Labels
Tests

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-28 00:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me